Add suppression of .DS_Store for NewlineAtEndOfFile #4176

Closed
Luolc opened this Issue Apr 9, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@Luolc
Contributor

Luolc commented Apr 9, 2017

We have added https://github.com/checkstyle/checkstyle/blob/master/config/checkstyle_non_main_files_checks.xml.

And it didn't suppress .DS_Store now. It does not affect the online CI but mac developers would always failed with mvn verify now if they enable .DS_Store on their PC.

Although we could tell them to banned the generation of .DS_Store manually. But I think it is better to add a simple <suppress checks="NewlineAtEndOfFile" files=".DS_Store"/> at the suppression file.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Apr 9, 2017

Member

I think we should add it to the list of excludes in the POM at https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L509 . We should add all .gitignore files to the pom exclude so we don't have any other problems.

Member

rnveach commented Apr 9, 2017

I think we should add it to the list of excludes in the POM at https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L509 . We should add all .gitignore files to the pom exclude so we don't have any other problems.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 13, 2017

Member

fix is merged.

Member

romani commented Apr 13, 2017

fix is merged.

@romani romani closed this Apr 13, 2017

AkshitaKukreja30 added a commit to AkshitaKukreja30/checkstyle that referenced this issue Apr 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment