Split and Organize Checkstyle inputs by Test in the blocks package #4220

Closed
subkrish opened this Issue Apr 15, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@subkrish
Contributor

subkrish commented Apr 15, 2017

subtask of #3891

Move / Make a copy of all test input files to a separate folder for all checks in blocks package.
Not any other Check should use new inputs.

@rnveach rnveach added the approved label Apr 15, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Apr 15, 2017

Member

pre-assigned to @subkrish

1 test and it's inputs per PR for now

Member

rnveach commented Apr 15, 2017

pre-assigned to @subkrish

1 test and it's inputs per PR for now

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 16, 2017

Subbu Dantu Subbu Dantu
Issue #4220: Modified AvoidNestedBlocksCheckTest.java and moved its i…
…nput files to the avoidnestedblocks subdirectory

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 16, 2017

Subbu Dantu Subbu Dantu
Issue #4220: Modified AvoidNestedBlocksCheckTest.java and moved its i…
…nput files to the avoidnestedblocks subdirectory

romani added a commit that referenced this issue Apr 17, 2017

Issue #4220: Modified AvoidNestedBlocksCheckTest.java and moved its i…
…nput files to the avoidnestedblocks subdirectory

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 18, 2017

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 18, 2017

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 18, 2017

Subbu Dantu Subbu Dantu
Issue #4220: Modified EmptyCatchBlockCheckTest.java and moved its inp…
…ut files to the emptycatchblock subdirectory

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 18, 2017

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 19, 2017

Subbu Dantu Subbu Dantu
Issue #4220: Modified EmptyCatchBlockCheckTest.java and moved its inp…
…ut files to the emptycatchblock subdirectory

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 19, 2017

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 19, 2017

Subbu Dantu Subbu Dantu
Issue #4220: Modified EmptyCatchBlockCheckTest.java and moved its inp…
…ut files to the emptycatchblock subdirectory

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 19, 2017

romani added a commit that referenced this issue Apr 20, 2017

romani added a commit that referenced this issue Apr 20, 2017

Issue #4220: Modified EmptyCatchBlockCheckTest.java and moved its inp…
…ut files to the emptycatchblock subdirectory

romani added a commit that referenced this issue Apr 22, 2017

@romani romani added the easy label Apr 22, 2017

@romani romani added this to the 7.7 milestone Apr 22, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 22, 2017

Member

fix is merged

Member

romani commented Apr 22, 2017

fix is merged

@romani romani closed this Apr 22, 2017

@subkrish

This comment has been minimized.

Show comment
Hide comment
@subkrish

subkrish Apr 22, 2017

Contributor

The two remaining checks in this package have not been pushed yet, i.e. NeedBracesCheckTest.java and RightCurlyCheckTest.java.

Contributor

subkrish commented Apr 22, 2017

The two remaining checks in this package have not been pushed yet, i.e. NeedBracesCheckTest.java and RightCurlyCheckTest.java.

@romani romani reopened this Apr 22, 2017

@romani romani removed this from the 7.7 milestone Apr 23, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 23, 2017

Member

commit 2036e7a is reverted from master as it caused build failure.
@subkrish , please rebase and send changes again.

Member

romani commented Apr 23, 2017

commit 2036e7a is reverted from master as it caused build failure.
@subkrish , please rebase and send changes again.

romani added a commit that referenced this issue Apr 23, 2017

Revert "Issue #4220: Modified EmptyBlockCheckTest.java and moved its …
…input files to the emptyblock subdirectory"

This reverts commit 2036e7a.

Kietzmann added a commit to Kietzmann/checkstyle that referenced this issue Apr 27, 2017

Kietzmann added a commit to Kietzmann/checkstyle that referenced this issue Apr 27, 2017

Kietzmann added a commit to Kietzmann/checkstyle that referenced this issue Apr 27, 2017

Kietzmann added a commit to Kietzmann/checkstyle that referenced this issue Apr 27, 2017

romani added a commit that referenced this issue Apr 28, 2017

romani added a commit that referenced this issue Apr 28, 2017

romani added a commit that referenced this issue Apr 28, 2017

@Kietzmann

This comment has been minimized.

Show comment
Hide comment
@Kietzmann

Kietzmann Apr 28, 2017

Contributor

@romani
Seems that this issue should be closed due to complete

Contributor

Kietzmann commented Apr 28, 2017

@romani
Seems that this issue should be closed due to complete

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Apr 28, 2017

Member

Agree, I see no inputs left in base folder.
Closing as done.

Member

rnveach commented Apr 28, 2017

Agree, I see no inputs left in base folder.
Closing as done.

@rnveach rnveach closed this Apr 28, 2017

@rnveach rnveach added this to the 7.7 milestone Apr 28, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment