Fix new TeamCity violations #4250

Closed
rnveach opened this Issue Apr 21, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@rnveach
Member

rnveach commented Apr 21, 2017

https://teamcity.jetbrains.com/viewLog.html?buildId=1048700&tab=Inspection&buildTypeId=Checkstyle_IdeaInspectionsPullRequest

Number of inspection errors 92 is 92 more than the provided threshold 0
Number of inspection warnings 192 is 192 more than the provided threshold 0

from logs:

[23:42:06] :	 [Step 2/2] Starting up IntelliJ IDEA 2017.1.2 (build IU-171.4249.21) ...done.

but latest available to download is 2017.1.1 . So this is just another experiment on TC with Intellij version.

We have repeatedly kept getting these errors in new PRs, so they must be valid and did another upgrade.

Code maturity issues
Deprecated member is still used (1)
 Code style issues
Replace Optional.isPresent() checks with functional-style expressions (3)
 Data flow issues
Scope of variable is too broad (Errors) (19)
 Declaration redundancy
Simplify stream API call chains (2)
 Dependency issues
Class with too many transitive dependents (Errors) (8)
 General
Annotator (2)
Redundant suppression (Errors) (2)
 Java 8
Anonymous type has shorter lambda alternative (2)
Lambda can be replaced with method reference (Errors) (1)
Loop can be collapsed with Stream API (Errors) (56)
Replace with Map.forEach (1)
Replace with single Map method (6)
 JUnit issues
Usage of obsolete 'junit.framework.Assert' method (Errors) (5)
 Naming conventions
Package naming convention (30)
 Probable bugs
Result of method call ignored (1)
Unused assignment (Errors) (1)
 RegExp
Duplicate branch in alternation (59)
Single character alternation (85)

Looking at a handfull, they seem to be valid and not false errors.

@Vladlis

This comment has been minimized.

Show comment
Hide comment
@Vladlis

Vladlis Apr 21, 2017

Member

We might need to reconsider our TC config. I'm not sure that we need to fix this for example:
Loop can be collapsed with Stream API (Errors) (56)

Member

Vladlis commented Apr 21, 2017

We might need to reconsider our TC config. I'm not sure that we need to fix this for example:
Loop can be collapsed with Stream API (Errors) (56)

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 21, 2017

Member

Let's disable these rules TC for now, they will be restored and fixed during GSoC project

Member

romani commented Apr 21, 2017

Let's disable these rules TC for now, they will be restored and fixed during GSoC project

@romani romani added the approved label Apr 21, 2017

romani added a commit that referenced this issue Apr 23, 2017

Issue #4250: fix for seleveral inspection violations(distance, ignore…
…d return value, deprecated package, extra variable initialization,..)

romani added a commit that referenced this issue Apr 23, 2017

Issue #4250: suppression of some IntellijIdea inspections till GSoC p…
…roject completion, to let TC web service pass the build

romani added a commit that referenced this issue Apr 23, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 23, 2017

Member

problem with rendering of 'Package naming convention (30)' is reported to TC support
https://teamcity-support.jetbrains.com/hc/en-us/requests/968250

Member

romani commented Apr 23, 2017

problem with rendering of 'Package naming convention (30)' is reported to TC support
https://teamcity-support.jetbrains.com/hc/en-us/requests/968250

romani added a commit that referenced this issue Apr 23, 2017

romani added a commit that referenced this issue Apr 23, 2017

romani added a commit that referenced this issue Apr 23, 2017

Issue #4250: fix for seleveral inspection violations(ignored return v…
…alue, deprecated package, extra variable initialization)

romani added a commit that referenced this issue Apr 23, 2017

Issue #4250: suppression of some IntellijIdea inspections till GSoC p…
…roject completion, to let TC web service pass the build

romani added a commit that referenced this issue Apr 23, 2017

Issue #4250: fix for seleveral inspection violations(ignored return v…
…alue, deprecated package, extra variable initialization)

romani added a commit that referenced this issue Apr 23, 2017

Issue #4250: suppression of some IntellijIdea inspections till GSoC p…
…roject completion, to let TC web service pass the build

@romani romani added this to the 7.7 milestone Apr 23, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 23, 2017

Member

fix is merged.
All fixes were done on IntellijIdea 2017.1.1 .

Member

romani commented Apr 23, 2017

fix is merged.
All fixes were done on IntellijIdea 2017.1.1 .

@romani romani closed this Apr 23, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

Issue #4250: fix for seleveral inspection violations(ignored return v…
…alue, deprecated package, extra variable initialization)

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

Issue #4250: suppression of some IntellijIdea inspections till GSoC p…
…roject completion, to let TC web service pass the build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment