New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc parser: Package names should permit digits in their name #4349

Closed
blerner opened this Issue May 12, 2017 · 1 comment

Comments

@blerner

blerner commented May 12, 2017

Per the JLS, https://docs.oracle.com/javase/specs/jls/se8/html/jls-7.html#jls-7.4.1, package names are permitted to be any sequence of identifiers. But JavadocParser.g4 (https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/com/puppycrawl/tools/checkstyle/grammars/javadoc/JavadocParser.g4#L907) specifies that package references use PACKAGE names as their leading tokens, which in turn are defined (https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/com/puppycrawl/tools/checkstyle/grammars/javadoc/JavadocLexer.g4#L122) without permitting digits.

@Vladlis Vladlis assigned ps-sp and unassigned ps-sp May 22, 2017

ps-sp added a commit to ps-sp/checkstyle that referenced this issue May 27, 2017

ps-sp added a commit to ps-sp/checkstyle that referenced this issue May 27, 2017

ps-sp added a commit to ps-sp/checkstyle that referenced this issue May 28, 2017

ps-sp added a commit to ps-sp/checkstyle that referenced this issue May 28, 2017

rnveach added a commit that referenced this issue May 28, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach May 28, 2017

Member

Fix is merged

Member

rnveach commented May 28, 2017

Fix is merged

@rnveach rnveach closed this May 28, 2017

@rnveach rnveach added the bug label May 28, 2017

@Vladlis Vladlis moved this from To Do to In Progress in Javadoc style coverage and parser optimization May 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment