Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Expand exception violation when haltOnException is off #4350
Violation message isn't very clear on what the underlying issue is. We don't know what class got the exception or what method. Regression was done on multiple files and checks. It would be very hard to go through each one by hand.
We need to expand the exception violation to be more informative without having to re-run with the option off.
I'm not sure if display should be full 'caused by' stack trace, last non-util checkstyle line in stack trace, or ....
@rnveach , it is better to update description to reproduce this problem in CLI, I do believe result will be the same.
format of message is
from your report:
586 is exception message ?? interesting case
exception message is null , not ideal but happens.
When exception happen and you need to show some details, nothing is more useful than full stacktrace. We will never predict place of exception, so stacktrace is only good content.
@rnveach , does it make sense ?
I updated it for the NullPointerException. I have been unable to track down the out of bounds exception right now.
Both are right.
Yes, this makes sense. This will be the most ideal for us in our regression reports.