New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Spotbugs tool in our build process #4373

Closed
romani opened this Issue May 25, 2017 · 6 comments

Comments

Projects
3 participants
@romani
Member

romani commented May 25, 2017

https://github.com/spotbugs/spotbugs

we need to start to use it.

@Nimfadora

This comment has been minimized.

Show comment
Hide comment
@Nimfadora

Nimfadora Jun 26, 2017

Contributor

@romani Are we intent to use spotbugs in parallel with FindBugs or instead of it? Cause in the doc said that:

SpotBugs is the spiritual successor of FindBugs, carrying on from the point where it left off with support of its community.

So, all checks from FindBugs must be included in the spotbugs.
If we plan to use it in parallel with findbugs we should figure out if its possible to do via Maven. Currently it doesn't have its own plugin. It relies on findbugs maven plugin. Here is more about it
I guess, we can use hazendaz's solution for now, but there is no confidence it will be supported in future. And it could be a problem to update in future.

Contributor

Nimfadora commented Jun 26, 2017

@romani Are we intent to use spotbugs in parallel with FindBugs or instead of it? Cause in the doc said that:

SpotBugs is the spiritual successor of FindBugs, carrying on from the point where it left off with support of its community.

So, all checks from FindBugs must be included in the spotbugs.
If we plan to use it in parallel with findbugs we should figure out if its possible to do via Maven. Currently it doesn't have its own plugin. It relies on findbugs maven plugin. Here is more about it
I guess, we can use hazendaz's solution for now, but there is no confidence it will be supported in future. And it could be a problem to update in future.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 26, 2017

Member

So, all checks from FindBugs must be included in the spotbugs.

must ...... it is not a true. It is just another tool and probably with big overlap to findbugs. Time will show what too is better and lives longer.

I guess, we can use hazendaz's solution for now, but there is no confidence it will be supported in future.

it is fine, as it become misbehave we always have option to disable it.

Member

romani commented Jun 26, 2017

So, all checks from FindBugs must be included in the spotbugs.

must ...... it is not a true. It is just another tool and probably with big overlap to findbugs. Time will show what too is better and lives longer.

I guess, we can use hazendaz's solution for now, but there is no confidence it will be supported in future.

it is fine, as it become misbehave we always have option to disable it.

@Nimfadora

This comment has been minimized.

Show comment
Hide comment
@Nimfadora

Nimfadora Jun 27, 2017

Contributor

@romani , I've applied spotbugs to our project and used our exclusions from findbugs. It looks like it didn't find nothing new:

[INFO] BugInstance size is 0
[INFO] Error size is 0
[INFO] No errors/warnings found
Contributor

Nimfadora commented Jun 27, 2017

@romani , I've applied spotbugs to our project and used our exclusions from findbugs. It looks like it didn't find nothing new:

[INFO] BugInstance size is 0
[INFO] Error size is 0
[INFO] No errors/warnings found

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 27, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 27, 2017

Member

@Nimfadora , please find out what new in this tool in comparison with findbugs.
After we merge support of it, please do one more PR with bad code to let us see violation from spotbugs.

By the way, we need to activate plugin in Travis validation, please use the same build item/command as pmd&findbug

Member

romani commented Jun 27, 2017

@Nimfadora , please find out what new in this tool in comparison with findbugs.
After we merge support of it, please do one more PR with bad code to let us see violation from spotbugs.

By the way, we need to activate plugin in Travis validation, please use the same build item/command as pmd&findbug

@romani romani moved this from To Do to In Progress in Practice What You Preach Jun 28, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 28, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 28, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 29, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 29, 2017

romani added a commit that referenced this issue Jun 30, 2017

@romani romani added this to the 8.0 milestone Jun 30, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 30, 2017

Member

fix is merged.

Member

romani commented Jun 30, 2017

fix is merged.

@romani romani closed this Jun 30, 2017

@romani romani moved this from In Progress to Done in Practice What You Preach Jun 30, 2017

@ThrawnCA

This comment has been minimized.

Show comment
Hide comment
@ThrawnCA

ThrawnCA Jul 4, 2017

I guess, we can use hazendaz's solution for now, but there is no confidence it will be supported in future.

The thing is, FindBugs hasn't had any support in quite a while :(

That's why SpotBugs exists, to continue community support.

ThrawnCA commented Jul 4, 2017

I guess, we can use hazendaz's solution for now, but there is no confidence it will be supported in future.

The thing is, FindBugs hasn't had any support in quite a while :(

That's why SpotBugs exists, to continue community support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment