New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strong, wildcard suppressions in configuration #4384

Closed
rnveach opened this Issue May 28, 2017 · 6 comments

Comments

Projects
4 participants
@rnveach
Member

rnveach commented May 28, 2017

Identified at #4378 (review) ,

We have very strong suppressions for the following files at

<suppress checks="." files=".*JavadocTokenTypes\.java"/>
<suppress checks="." files=".*ParseTreeBuilder\.java"/>
: JavadocTokenTypes and ParseTreeBuilder.

Suppressing everything means we do no simple validation like import ordering or curly positioning. We should change this to suppress specific checks and the ones that are easy should be fixed and removed.

@MEZk

This comment has been minimized.

Show comment
Hide comment
@MEZk

MEZk May 30, 2017

Contributor

Should this be a part of GSoC project?

Contributor

MEZk commented May 30, 2017

Should this be a part of GSoC project?

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach May 31, 2017

Member

I don't see this as a very strong connection, imo, but this should be a simple task.

Member

rnveach commented May 31, 2017

I don't see this as a very strong connection, imo, but this should be a simple task.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 7, 2017

Member

it is good part of "Practice what you preach".

Member

romani commented Jun 7, 2017

it is good part of "Practice what you preach".

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 22, 2017

Member

analysis of suppression was done at #4985.
After merge of this PR, It is required to fix only JavadocParagraph violations.

Member

romani commented Aug 22, 2017

analysis of suppression was done at #4985.
After merge of this PR, It is required to fix only JavadocParagraph violations.

romani added a commit that referenced this issue Aug 22, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 22, 2017

Member

@Nimfadora , PR is merged, please provide a fix for JavadocParagraph.

Member

romani commented Aug 22, 2017

@Nimfadora , PR is merged, please provide a fix for JavadocParagraph.

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Aug 30, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Aug 30, 2017

romani added a commit that referenced this issue Aug 31, 2017

@romani romani added this to the 8.2 milestone Aug 31, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 31, 2017

Member

JavadocParagraph is fixed.

Member

romani commented Aug 31, 2017

JavadocParagraph is fixed.

@romani romani closed this Aug 31, 2017

@rnveach rnveach moved this from To Do to Done in Practice What You Preach Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment