New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pitest: increase mutation coverage for pitest-checkstyle-api profile to 100% #4394

Closed
Nimfadora opened this Issue May 31, 2017 · 3 comments

Comments

Projects
2 participants
@Nimfadora
Contributor

Nimfadora commented May 31, 2017

We created pitest profiles for non-checks code in #4367 . Currently, we should increase coverage for pitest-checkstyle-api profile up to 100%.
This issue is a subtask of #3708

Also in scope of this task, we should remove exclusion of com.puppycrawl.tools.checkstyle.api.Check class from the profile, as it has no methods or fields and does not influence mutation coverage.

Current threshold of pitest-checkstyle-api profile: 45

@Nimfadora Nimfadora changed the title from pitest: increase mutation coverage for checkstyle-api package to 100% to pitest: increase mutation coverage for pitest-checkstyle-api profile to 100% May 31, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 16, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 16, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 17, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 19, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 19, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 20, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 21, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 21, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 21, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 21, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 21, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 21, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 22, 2017

romani added a commit that referenced this issue Jun 23, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 3, 2017

@romani romani moved this from To Do to In Progress in Practice What You Preach Jul 4, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jul 6, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jul 7, 2017

romani added a commit that referenced this issue Jul 7, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 8, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 8, 2017

romani added a commit that referenced this issue Jul 9, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jul 12, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 14, 2017

romani added a commit that referenced this issue Jul 14, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jul 17, 2017

romani added a commit that referenced this issue Jul 17, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 17, 2017

romani added a commit that referenced this issue Jul 17, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 17, 2017

Member

profile is 100%

Member

romani commented Jul 17, 2017

profile is 100%

@romani romani closed this Jul 17, 2017

@romani romani moved this from To Do to Done in Practice What You Preach Jul 17, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 28, 2017

Member

@Nimfadora ,

from #5015 .

there is regression:
Survived items:target/pit-reports/201708281641/com.puppycrawl.tools.checkstyle.api/SeverityLevelCounter.java.html:<td class='survived'> target/pit-reports/201708281641/com.puppycrawl.tools.checkstyle.api/SeverityLevelCounter.java.html:<td class='covered'><pre><span class='survived'> count.set(0);</span></pre></td></tr>

please help us to fix this.

Member

romani commented Aug 28, 2017

@Nimfadora ,

from #5015 .

there is regression:
Survived items:target/pit-reports/201708281641/com.puppycrawl.tools.checkstyle.api/SeverityLevelCounter.java.html:<td class='survived'> target/pit-reports/201708281641/com.puppycrawl.tools.checkstyle.api/SeverityLevelCounter.java.html:<td class='covered'><pre><span class='survived'> count.set(0);</span></pre></td></tr>

please help us to fix this.

@romani romani reopened this Aug 28, 2017

@romani romani moved this from Done to To Do in Practice What You Preach Aug 30, 2017

romani added a commit that referenced this issue Aug 30, 2017

romani added a commit that referenced this issue Aug 31, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Sep 1, 2017

romani added a commit that referenced this issue Sep 2, 2017

@romani romani added this to the 8.3 milestone Sep 2, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Sep 2, 2017

Member

final fix is mergged

Member

romani commented Sep 2, 2017

final fix is mergged

@romani romani closed this Sep 2, 2017

@rnveach rnveach moved this from To Do to Done in Practice What You Preach Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment