New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pitest: increase mutation coverage for pitest-checkstyle-utils profile to 100% #4395

Closed
Nimfadora opened this Issue May 31, 2017 · 5 comments

Comments

Projects
2 participants
@Nimfadora
Contributor

Nimfadora commented May 31, 2017

We created pitest profiles for non-checks code in #4367. Currently, we should increase coverage for pitest-checkstyle-utils profile up to 100%.
This issue is a subtask of #3708

Current threshold of pitest-checkstyle-utils profile: 40

@Nimfadora Nimfadora changed the title from pitest: increase mutation coverage for checkstyle-utils package to 100% to pitest: increase mutation coverage for pitest-checkstyle-utils profile to 100% May 31, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 7, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 7, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 7, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 7, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 7, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 8, 2017

romani added a commit that referenced this issue Jun 9, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 10, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 12, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 12, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 12, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 12, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 14, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 14, 2017

romani added a commit that referenced this issue Jun 19, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 21, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 21, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 22, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 22, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jun 23, 2017

romani added a commit that referenced this issue Jun 23, 2017

@romani romani moved this from To Do to In Progress in Practice What You Preach Jul 4, 2017

@Nimfadora

This comment has been minimized.

Show comment
Hide comment
@Nimfadora

Nimfadora Jul 5, 2017

Contributor

@romani I'm stuck with this package at this stage, please provide assistance on fixing mutations remained

Contributor

Nimfadora commented Jul 5, 2017

@romani I'm stuck with this package at this stage, please provide assistance on fixing mutations remained

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 5, 2017

Member

https://nimfadora.github.io/pr/com.puppycrawl.tools.checkstyle.utils/CheckUtils.java.html

type.getChildCount(TokenTypes.LITERAL_VOID) > 0

type could have only one void so change it to findFirstChild or smth similar from our utils.

&& newNode.getColumnNo() < currentNode.getColumnNo()

please make UT that require this line on custom AST structure. non-functional test.

================

https://nimfadora.github.io/pr/com.puppycrawl.tools.checkstyle.utils/TokenUtils.java.html

remove this line.

===============================================

https://nimfadora.github.io/pr/com.puppycrawl.tools.checkstyle.utils/JavadocUtils.java.html
4)

            if (!Modifier.isPublic(field.getModifiers())
                    || field.getType() != Integer.TYPE) {
                continue;
            }

this code is required to skip private static final int RULE_TYPES_OFFSET = 10000; please make assert that 10000 is not present in result map.

all cases from lookForInlineTags , getPreviousSibling, getTokenName

please make non functional UTs to cover them.

Member

romani commented Jul 5, 2017

https://nimfadora.github.io/pr/com.puppycrawl.tools.checkstyle.utils/CheckUtils.java.html

type.getChildCount(TokenTypes.LITERAL_VOID) > 0

type could have only one void so change it to findFirstChild or smth similar from our utils.

&& newNode.getColumnNo() < currentNode.getColumnNo()

please make UT that require this line on custom AST structure. non-functional test.

================

https://nimfadora.github.io/pr/com.puppycrawl.tools.checkstyle.utils/TokenUtils.java.html

remove this line.

===============================================

https://nimfadora.github.io/pr/com.puppycrawl.tools.checkstyle.utils/JavadocUtils.java.html
4)

            if (!Modifier.isPublic(field.getModifiers())
                    || field.getType() != Integer.TYPE) {
                continue;
            }

this code is required to skip private static final int RULE_TYPES_OFFSET = 10000; please make assert that 10000 is not present in result map.

all cases from lookForInlineTags , getPreviousSibling, getTokenName

please make non functional UTs to cover them.

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 7, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 7, 2017

romani added a commit that referenced this issue Jul 7, 2017

@romani romani added this to the 8.1 milestone Jul 7, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 7, 2017

Member

last fix is merged

Member

romani commented Jul 7, 2017

last fix is merged

@romani romani closed this Jul 7, 2017

@romani romani moved this from In Progress to Done in Practice What You Preach Jul 7, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 30, 2017

Member

issue is reopened to fix last missed coverage line

Member

romani commented Aug 30, 2017

issue is reopened to fix last missed coverage line

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 31, 2017

Member

final fix is merged

Member

romani commented Aug 31, 2017

final fix is merged

@romani romani closed this Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment