New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pitest: increase mutation coverage for pitest-check-header profile to 100% #4401

Closed
Nimfadora opened this Issue May 31, 2017 · 2 comments

Comments

Projects
2 participants
@Nimfadora
Contributor

Nimfadora commented May 31, 2017

We should increase coverage for pitest-check-header profile up to 100%.
This issue is a subtask of #3708

Current threshold of pitest-checkstyle-header profile: 78

@Nimfadora Nimfadora changed the title from pitest: add profile(s) for remaining checks to pitest: increase mutation coverage for pitest-check-header profile to 100% May 31, 2017

@romani romani added the GSoC2017 label May 31, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 1, 2017

@Nimfadora

This comment has been minimized.

Show comment
Hide comment
@Nimfadora

Nimfadora Jun 1, 2017

Contributor

@romani, in com.puppycrawl.tools.checkstyle.checks.header.RegexpHeaderCheck#postProcessHeaderLines there is a line like this: headerRegexps.clear();
It seems unnecessary, as I struggled quite a lot of time trying to brake it, and all my attempts failed. It can not be tested either.
The case is that this line prevents mutation coverage of 100% for this class, as when it is deleted no tests fail. I suggest to delete this line.

Contributor

Nimfadora commented Jun 1, 2017

@romani, in com.puppycrawl.tools.checkstyle.checks.header.RegexpHeaderCheck#postProcessHeaderLines there is a line like this: headerRegexps.clear();
It seems unnecessary, as I struggled quite a lot of time trying to brake it, and all my attempts failed. It can not be tested either.
The case is that this line prevents mutation coverage of 100% for this class, as when it is deleted no tests fail. I suggest to delete this line.

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 1, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 1, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 1, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 1, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 1, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 1, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 2, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 3, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 3, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jun 5, 2017

romani added a commit that referenced this issue Jun 5, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 21, 2017

romani added a commit that referenced this issue Jul 22, 2017

@romani romani added this to the 8.1 milestone Jul 22, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 22, 2017

Member

fix is merged

Member

romani commented Jul 22, 2017

fix is merged

@romani romani closed this Jul 22, 2017

@romani romani moved this from To Do to Done in Practice What You Preach Jul 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment