New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple name conflict of Checks from thirdparty checks will cause exception in run time #4414

Closed
romani opened this Issue Jun 3, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@romani
Member

romani commented Jun 3, 2017

the same problem as in #4387

I did ugly fix to make it work as before, without testing, that need to be fixed in this issue.

We will still have the same exception then few Checks from few thirparty jars are in conflict.
We need to give user clear message how to resolve the issue.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jun 5, 2017

Member

@Luolc can you help us finally finish this based on our discussions in previous PR?
We need to finish this quick to do another release and go to CS8 as some GSoC items will require it.

Member

rnveach commented Jun 5, 2017

@Luolc can you help us finally finish this based on our discussions in previous PR?
We need to finish this quick to do another release and go to CS8 as some GSoC items will require it.

Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 7, 2017

Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 7, 2017

Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 7, 2017

Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 7, 2017

Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 7, 2017

Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 7, 2017

Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 7, 2017

Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 12, 2017

Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 13, 2017

Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 13, 2017

Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 13, 2017

romani added a commit that referenced this issue Jun 14, 2017

@romani romani added the bug label Jun 14, 2017

@romani romani added this to the 7.8.2 milestone Jun 14, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 14, 2017

Member

fix is merged.
@Luolc , thanks a lot for your hard work to resolve issue.

Member

romani commented Jun 14, 2017

fix is merged.
@Luolc , thanks a lot for your hard work to resolve issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment