Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple name conflict of Checks from thirdparty checks will cause exception in run time #4414

Closed
romani opened this issue Jun 3, 2017 · 2 comments
Closed

Simple name conflict of Checks from thirdparty checks will cause exception in run time #4414

romani opened this issue Jun 3, 2017 · 2 comments
Assignees
@Luolc
Labels
approved bug
Milestone
7.8.2

Comments

@romani
Copy link
Member

romani commented Jun 3, 2017

the same problem as in #4387

I did ugly fix to make it work as before, without testing, that need to be fixed in this issue.

We will still have the same exception then few Checks from few thirparty jars are in conflict.
We need to give user clear message how to resolve the issue.
@romani romani added the approved label Jun 3, 2017
This was referenced Jun 3, 2017
Closed
Closed
@rnveach
Copy link
Member

rnveach commented Jun 5, 2017 •
edited

@Luolc can you help us finally finish this based on our discussions in previous PR?
We need to finish this quick to do another release and go to CS8 as some GSoC items will require it.

Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 7, 2017
@Luolc
Issue checkstyle#4414: Simple name conflict of Checks from thirdparty…
1bb72ee 
… checks will cause exception in run time
Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 7, 2017
@Luolc
Issue checkstyle#4414: Simple name conflict of Checks from thirdparty…
49ca9a0 
… checks will cause exception in run time
Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 7, 2017
@Luolc
Issue checkstyle#4414: Simple name conflict of Checks from thirdparty…
42c42b5 
… checks will cause exception in run time
Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 7, 2017
@Luolc
Issue checkstyle#4414: change ambiguous module names to full qualifie…
0524017 
…d ones
@Luolc Luolc mentioned this issue Jun 7, 2017
Merged
Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 7, 2017
@Luolc
Issue checkstyle#4414: change ambiguous module names to full qualifie…
249346e 
…d ones
Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 7, 2017
@Luolc
Issue checkstyle#4414: Simple name conflict of Checks from thirdparty…
4f38082 
… checks will cause exception in run time
Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 7, 2017
@Luolc
Issue checkstyle#4414: Simple name conflict of Checks from thirdparty…
76a6e1b 
… checks will cause exception in run time
Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 12, 2017
@Luolc
Issue checkstyle#4414: Simple name conflict of Checks from thirdparty…
221ff9a 
… checks will cause exception in run time
Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 13, 2017
@Luolc
Issue checkstyle#4414: Simple name conflict of Checks from thirdparty…
b9052c1 
… checks will cause exception in run time
Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 13, 2017
@Luolc
Issue checkstyle#4414: Simple name conflict of Checks from thirdparty…
8d18b8f 
… checks will cause exception in run time
Luolc added a commit to Luolc/checkstyle that referenced this issue Jun 13, 2017
@Luolc
Issue checkstyle#4414: Simple name conflict of Checks from thirdparty…
d3d305e 
… checks will cause exception in run time
romani pushed a commit that referenced this issue Jun 14, 2017
@Luolc @romani
Issue #4414: Simple name conflict of Checks from thirdparty checks wi…
b024af7 
…ll cause exception in run time
@romani romani added the bug label Jun 14, 2017
@romani romani added this to the 7.8.2 milestone Jun 14, 2017
@romani
Copy link
Member Author

romani commented Jun 14, 2017

fix is merged.
@Luolc , thanks a lot for your hard work to resolve issue.

@romani romani closed this as completed Jun 14, 2017
@romani romani mentioned this issue Jun 14, 2017
Closed
romani added a commit that referenced this issue Jun 14, 2017
@romani
Issue #4414: remove allowance of PackageObjectFactory coverage to be …
4f2fa98 
…non 100%
@romani romani mentioned this issue Jun 14, 2017
Merged
romani added a commit that referenced this issue Jun 15, 2017
@romani
Issue #4414: remove allowance of PackageObjectFactory coverage to be …
0b27693 
…non 100%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Luolc Luolc

Labels
approved bug
Projects
None yet
Milestone
7.8.2
Development

No branches or pull requests
3 participants
@romani @rnveach @Luolc