New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pmd: fix TestClassWithoutTestCases violations in test classes #4518

Closed
romani opened this Issue Jun 24, 2017 · 1 comment

Comments

Projects
2 participants
@romani
Member

romani commented Jun 24, 2017

Subtask of #877
We should fix all violations of this type in test classes.

http://pmd.sourceforge.net/pmd-4.3.0/rules/junit.html#TestClassWithoutTestCases

Test classes end with the suffix Test. Having a non-test class with that name is not a good practice, since most people will assume it is a test case. Test classes have test methods named testXXX.

all test methods should start with "test" prefix - "testXXXXXXX".
suffix "TestX" from methods should be removed.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 24, 2017

Member

fix is merged.

Member

romani commented Jun 24, 2017

fix is merged.

@romani romani closed this Jun 24, 2017

@romani romani added this to In Progress in Practice What You Preach Jun 28, 2017

@romani romani moved this from In Progress to Done in Practice What You Preach Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment