New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and Organize Checkstyle inputs by Test for checks in 'indentation' package #4538

Closed
subkrish opened this Issue Jun 27, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@subkrish
Contributor

subkrish commented Jun 27, 2017

subtask of #3891

Move / Make a copy of all test input files to a separate folder for all checks in 'indentation' package.
Not any other Check should use new inputs.

@subkrish

This comment has been minimized.

Show comment
Hide comment
@subkrish

subkrish Jun 27, 2017

Contributor

I'm on it. 1 test and its inputs per PR.

Contributor

subkrish commented Jun 27, 2017

I'm on it. 1 test and its inputs per PR.

@rnveach rnveach added the approved label Jun 27, 2017

subkrish added a commit to subkrish/checkstyle that referenced this issue Jun 27, 2017

Issue #4538: Modified CommentsIndentationCheckTest.java and moved its…
… input files to the commentsindentation subdirectory

subkrish added a commit to subkrish/checkstyle that referenced this issue Jun 27, 2017

rnveach added a commit that referenced this issue Jun 27, 2017

Issue #4538: Modified CommentsIndentationCheckTest.java and moved its…
… input files to the commentsindentation subdirectory

@romani romani added this to the 8.0 milestone Jun 28, 2017

rnveach added a commit that referenced this issue Jun 28, 2017

subkrish added a commit to subkrish/checkstyle that referenced this issue Jun 28, 2017

subkrish added a commit to subkrish/checkstyle that referenced this issue Jun 29, 2017

subkrish added a commit to subkrish/checkstyle that referenced this issue Jun 29, 2017

romani added a commit that referenced this issue Jun 29, 2017

subkrish added a commit to subkrish/checkstyle that referenced this issue Jun 29, 2017

@subkrish

This comment has been minimized.

Show comment
Hide comment
@subkrish

subkrish Jun 29, 2017

Contributor

@romani @rnveach I think with this last PR the issue can be closed once the PR is reviewed and merged.

Contributor

subkrish commented Jun 29, 2017

@romani @rnveach I think with this last PR the issue can be closed once the PR is reviewed and merged.

rnveach added a commit that referenced this issue Jun 30, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jun 30, 2017

Member

Fixes were merged

Member

rnveach commented Jun 30, 2017

Fixes were merged

@rnveach rnveach closed this Jun 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment