New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore wercker CIs that have custom Checks #4582

Closed
rnveach opened this Issue Jul 2, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@rnveach
Member

rnveach commented Jul 2, 2017

Broken off from #605 in commit 9135ea3 ,

3 wercker CIs had to be disabled to pass the build. We need to send PRs to them to be able to restore them to usage in our CI.

  1. NoErrorTest - XWiki
  2. NoErrorTest - Hibernate Search
  3. NoErrorTest - checkstyle's sevntu

rnveach added a commit to rnveach/checkstyle that referenced this issue Jul 2, 2017

rnveach added a commit that referenced this issue Jul 2, 2017

@rnveach rnveach added this to the 8.1 milestone Jul 2, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jul 2, 2017

Member

Testing changes in xwiki master gave me this error:

[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for com.google.guava:guava:20.0 paths to dependency are:
+-org.xwiki.commons:xwiki-commons-tool-verification-resources:9.6-SNAPSHOT
+-com.puppycrawl.tools:checkstyle:8.0-SNAPSHOT
+-com.google.guava:guava:20.0 (managed) <-- com.google.guava:guava:22.0
and
+-org.xwiki.commons:xwiki-commons-tool-verification-resources:9.6-SNAPSHOT
+-com.puppycrawl.tools:checkstyle:8.0-SNAPSHOT
+-com.google.guava:guava:20.0

xwiki needs to exclude guava in 2 places in their POM to pass this error.

Member

rnveach commented Jul 2, 2017

Testing changes in xwiki master gave me this error:

[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for com.google.guava:guava:20.0 paths to dependency are:
+-org.xwiki.commons:xwiki-commons-tool-verification-resources:9.6-SNAPSHOT
+-com.puppycrawl.tools:checkstyle:8.0-SNAPSHOT
+-com.google.guava:guava:20.0 (managed) <-- com.google.guava:guava:22.0
and
+-org.xwiki.commons:xwiki-commons-tool-verification-resources:9.6-SNAPSHOT
+-com.puppycrawl.tools:checkstyle:8.0-SNAPSHOT
+-com.google.guava:guava:20.0

xwiki needs to exclude guava in 2 places in their POM to pass this error.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jul 2, 2017

Member

PR to xwiki is created. xwiki/xwiki-commons#17
We require more changes to their POM to restore regression.

Member

rnveach commented Jul 2, 2017

PR to xwiki is created. xwiki/xwiki-commons#17
We require more changes to their POM to restore regression.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jul 3, 2017

Member

From xwiki:

The issue with Guava can be followed at https://jira.xwiki.org/browse/XCOMMONS-1155.

Member

rnveach commented Jul 3, 2017

From xwiki:

The issue with Guava can be followed at https://jira.xwiki.org/browse/XCOMMONS-1155.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jul 4, 2017

Member

I started new PR for xwiki's POM: xwiki/xwiki-commons#18

Member

rnveach commented Jul 4, 2017

I started new PR for xwiki's POM: xwiki/xwiki-commons#18

rnveach added a commit to rnveach/checkstyle that referenced this issue Jul 4, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jul 4, 2017

romani added a commit that referenced this issue Jul 5, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 5, 2017

Member

fix is merged

Member

romani commented Jul 5, 2017

fix is merged

@romani romani closed this Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment