New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and Organize Checkstyle inputs by Test for checks in 'regexp' package #4585

Closed
romani opened this Issue Jul 2, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@romani
Member

romani commented Jul 2, 2017

subtask of #3891

Move / Make a copy of all test input files to a separate folder for all checks in 'regexp' package.
Not any other Check should use new inputs.

There are a lot of other issues/commit that named as "Split and Organize Checkstyle inputs ..." , you can find example of what to do there.

all files should be in subfolders on completion - https://github.com/checkstyle/checkstyle/tree/master/src/test/resources/com/puppycrawl/tools/checkstyle/checks/regexp

@romani

This comment has been minimized.

Show comment
Hide comment
@romani
Member

romani commented Jul 2, 2017

@TarunISCO

This comment has been minimized.

Show comment
Hide comment
@TarunISCO

TarunISCO Jul 2, 2017

I am on it.

TarunISCO commented Jul 2, 2017

I am on it.

@romani romani added the miscellaneous label Jul 6, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 20, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 20, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 20, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 20, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 20, 2017

romani added a commit that referenced this issue Jul 20, 2017

romani added a commit that referenced this issue Jul 20, 2017

romani added a commit that referenced this issue Jul 20, 2017

romani added a commit that referenced this issue Jul 20, 2017

romani added a commit that referenced this issue Jul 20, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 20, 2017

Member

@Kietzmann , thanks a lot for updates , there 3 files left in folder.

Member

romani commented Jul 20, 2017

@Kietzmann , thanks a lot for updates , there 3 files left in folder.

Kietzmann added a commit to Kietzmann/checkstyle that referenced this issue Jul 20, 2017

romani added a commit that referenced this issue Jul 20, 2017

@romani romani added this to the 8.1 milestone Jul 20, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 20, 2017

Member

final fix is merged.
@Kietzmann , thanks a lot !

Member

romani commented Jul 20, 2017

final fix is merged.
@Kietzmann , thanks a lot !

@romani romani closed this Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment