New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and Organize Checkstyle inputs by Test for checks in 'javadoc' package #4586

Closed
romani opened this Issue Jul 2, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@romani
Member

romani commented Jul 2, 2017

subtask of #3891

Move / Make a copy of all test input files to a separate folder for all checks in 'javadoc' package.
Not any other Check should use new inputs.

There are a lot of other issues/commit that named as "Split and Organize Checkstyle inputs ..." , you can find example of what to do there.

All files should be in subfolders on completion - https://github.com/checkstyle/checkstyle/tree/master/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc

@djydewang

This comment has been minimized.

Show comment
Hide comment
@djydewang

djydewang Jul 3, 2017

Contributor

Please assign me this issue.

Contributor

djydewang commented Jul 3, 2017

Please assign me this issue.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 3, 2017

Member

ok, you got it.

Member

romani commented Jul 3, 2017

ok, you got it.

@djydewang

This comment has been minimized.

Show comment
Hide comment
@djydewang

djydewang Jul 4, 2017

Contributor

@romani I have finished all task except when I test JavadocMethodCheckTest.java with InputJavadocMethodTags.java(InputTags.java) This is Failure:
org.junit.ComparisonFailure: error message 10 expected:<...docMethodTags.java:3[20:9: 缺少 Javadoc] 。> but was:<...docMethodTags.java:3[3: 需要一个 Javadoc注释 @return] 。>
I find actual is really different from expect when I debug it.

Contributor

djydewang commented Jul 4, 2017

@romani I have finished all task except when I test JavadocMethodCheckTest.java with InputJavadocMethodTags.java(InputTags.java) This is Failure:
org.junit.ComparisonFailure: error message 10 expected:<...docMethodTags.java:3[20:9: 缺少 Javadoc] 。> but was:<...docMethodTags.java:3[3: 需要一个 Javadoc注释 @return] 。>
I find actual is really different from expect when I debug it.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 4, 2017

Member

Without review of your code changes it is hard to help, but no changes in it's are expected. please do PR to let me see all your changes and exact place it fails

Member

romani commented Jul 4, 2017

Without review of your code changes it is hard to help, but no changes in it's are expected. please do PR to let me see all your changes and exact place it fails

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 5, 2017

@romani romani added the miscellaneous label Jul 6, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 6, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 6, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 6, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 6, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 6, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 7, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 7, 2017

romani added a commit that referenced this issue Jul 8, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 8, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 8, 2017

romani added a commit that referenced this issue Jul 8, 2017

romani added a commit that referenced this issue Jul 8, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 8, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 8, 2017

Issue #4586: Moved InputCorrectJavadocParagraph.java to javadocparagr…
…aph subdirectory and Copied InputInCorrectJavadocParagraph.java to subdirectory

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 8, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 8, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 8, 2017

Issue #4586: Moved InputCorrectJavadocParagraph.java to javadocparagr…
…aph subdirectory and Copied InputInCorrectJavadocParagraph.java to subdirectory

romani added a commit that referenced this issue Jul 9, 2017

romani added a commit that referenced this issue Jul 9, 2017

Issue #4586: Moved InputCorrectJavadocParagraph.java to javadocparagr…
…aph subdirectory and Copied InputInCorrectJavadocParagraph.java to subdirectory

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 9, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 9, 2017

romani added a commit that referenced this issue Jul 9, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 9, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 9, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 9, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 9, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 9, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 10, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 10, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 10, 2017

romani added a commit that referenced this issue Jul 10, 2017

romani added a commit that referenced this issue Jul 10, 2017

romani added a commit that referenced this issue Jul 10, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 10, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 10, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 10, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 10, 2017

romani added a commit that referenced this issue Jul 10, 2017

romani added a commit that referenced this issue Jul 10, 2017

romani added a commit that referenced this issue Jul 10, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 10, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 10, 2017

romani added a commit that referenced this issue Jul 10, 2017

romani added a commit that referenced this issue Jul 10, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 11, 2017

romani added a commit that referenced this issue Jul 11, 2017

@romani romani added this to the 8.1 milestone Jul 11, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 11, 2017

Member

Fix is merged.

@djydewang , thanks a lot for your help. You are ready for more complicated issue now, let me know if need help to choose next issue

Member

romani commented Jul 11, 2017

Fix is merged.

@djydewang , thanks a lot for your help. You are ready for more complicated issue now, let me know if need help to choose next issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment