New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated AbstractDeclarationCollector, AbstractFormatCheck, AbstractOptionCheck #4677

Closed
romani opened this Issue Jul 9, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@romani
Member

romani commented Jul 9, 2017

remove deprecated:

  • AbstractDeclarationCollector,
  • AbstractFormatCheck,
  • AbstractOptionCheck

removal is required also from all our configs (pom, suppressions, .....)

@Kietzmann

This comment has been minimized.

Show comment
Hide comment
@Kietzmann

Kietzmann Jul 9, 2017

Contributor

I'm on it

Contributor

Kietzmann commented Jul 9, 2017

I'm on it

@Kietzmann

This comment has been minimized.

Show comment
Hide comment
@Kietzmann

Kietzmann Jul 9, 2017

Contributor

@romani
Should I remove AbstractTypeAwareCheck also(it is deprecated too)?

Contributor

Kietzmann commented Jul 9, 2017

@romani
Should I remove AbstractTypeAwareCheck also(it is deprecated too)?

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jul 9, 2017

Member

@Kietzmann No, 1 non-deprecated check is depended on it for now.

Member

rnveach commented Jul 9, 2017

@Kietzmann No, 1 non-deprecated check is depended on it for now.

romani added a commit that referenced this issue Jul 10, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 10, 2017

Member

AbstractTypeAwareCheck will be removed at #4676 .

Member

romani commented Jul 10, 2017

AbstractTypeAwareCheck will be removed at #4676 .

@Kietzmann

This comment has been minimized.

Show comment
Hide comment
@Kietzmann

Kietzmann Jul 10, 2017

Contributor

Please close the issue

Contributor

Kietzmann commented Jul 10, 2017

Please close the issue

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jul 10, 2017

Member

Fix was merged

Member

rnveach commented Jul 10, 2017

Fix was merged

@rnveach rnveach closed this Jul 10, 2017

@rnveach rnveach added this to the 8.1 milestone Jul 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment