New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review all suppressed IntellijIdea inspections with comment 'till ...' #4681

Closed
romani opened this Issue Jul 9, 2017 · 18 comments

Comments

Projects
3 participants
@romani
Member

romani commented Jul 9, 2017

https://github.com/checkstyle/checkstyle/blob/master/config/intellij-idea-inspections.xml

comments like:
Disabled till GSoC completion
disabled till https://githu......
...
any other place where ... enabled="false" ...

Sub issues: #3435 , #3301

TODO:

  1. Active all suppressed by "till" inspections, share report with us to review and receive guidance on what to fix and how.
  2. if no reason for suppression is provided , reason comment should be created (discussed with me).
  3. all suppressed cases need to reviewed and fixed is reasonable (DO NOT blindly follow recommendations from inspection)
@Nimfadora

This comment has been minimized.

Show comment
Hide comment
@Nimfadora

Nimfadora Jul 10, 2017

Contributor

@romani
All suppressions with #till comment you can find here
Here is the list of these suppressions:

#Disabled till GSoC completion
TooBroadScope
SingleCharAlternation
SimplifyStreamApiCallChains
OptionalIsPresent
Java8MapForEach
Java8MapApi
DuplicateAlternationBranch
Convert2streamapi
Convert2MethodRef
AnonymousHasLambdaAlternative

#disabled till https://github.com/checkstyle/checkstyle/issues/3301
ThrowFromFinallyBlock

#Disabled till issue with rendering exact list of violation is resolved on TC service
PackageNamingConvention

SuppressionAnnotation
#Till https://github.com/checkstyle/checkstyle/issues/3066
option=ProhibitedExceptionCaught

#suppressed till prolem is resolved
ClassWithTooManyTransitiveDependents enabled="true"
ClassWithTooManyTransitiveDependencies

List of suppressions without comments is here, report on them is too big to be extracted, so if it is needed I will generate it on specific checks.

Contributor

Nimfadora commented Jul 10, 2017

@romani
All suppressions with #till comment you can find here
Here is the list of these suppressions:

#Disabled till GSoC completion
TooBroadScope
SingleCharAlternation
SimplifyStreamApiCallChains
OptionalIsPresent
Java8MapForEach
Java8MapApi
DuplicateAlternationBranch
Convert2streamapi
Convert2MethodRef
AnonymousHasLambdaAlternative

#disabled till https://github.com/checkstyle/checkstyle/issues/3301
ThrowFromFinallyBlock

#Disabled till issue with rendering exact list of violation is resolved on TC service
PackageNamingConvention

SuppressionAnnotation
#Till https://github.com/checkstyle/checkstyle/issues/3066
option=ProhibitedExceptionCaught

#suppressed till prolem is resolved
ClassWithTooManyTransitiveDependents enabled="true"
ClassWithTooManyTransitiveDependencies

List of suppressions without comments is here, report on them is too big to be extracted, so if it is needed I will generate it on specific checks.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 11, 2017

Member

@Nimfadora ,

https://nimfadora.github.io/idea/suppressed.html

All link to sources are like
file:///home/valeria/IdeaProjects/checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/CheckerTest.java#3422 , hard to use report from cell phone.

it would be awesome if you did search/replace for all links in files to github repository. sed could do this for you by one command. Please do. Looks like it not the last time you need to share violations.
While I work on that reports, you can fight with violations that are clear for you.

List of suppressions without comments is here, report on them is too big to be extracted, so if it is needed I will generate it on specific checks.

impressive amount of missed validations. Please try split all of them in 5-7 reports and share in github.io . Please update reports to have a links to github for sources it will help me to give you guidance on the go. We will process all of them in separate 5-7 issues. For most of them I will provide reason to suppress.

I do believe that part of them could be applied to our code without any violation. If you see some rules, feel free to activate them.

  1. After you generate me reports to let me work on reasons to suppress, you can do
Member

romani commented Jul 11, 2017

@Nimfadora ,

https://nimfadora.github.io/idea/suppressed.html

All link to sources are like
file:///home/valeria/IdeaProjects/checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/CheckerTest.java#3422 , hard to use report from cell phone.

it would be awesome if you did search/replace for all links in files to github repository. sed could do this for you by one command. Please do. Looks like it not the last time you need to share violations.
While I work on that reports, you can fight with violations that are clear for you.

List of suppressions without comments is here, report on them is too big to be extracted, so if it is needed I will generate it on specific checks.

impressive amount of missed validations. Please try split all of them in 5-7 reports and share in github.io . Please update reports to have a links to github for sources it will help me to give you guidance on the go. We will process all of them in separate 5-7 issues. For most of them I will provide reason to suppress.

I do believe that part of them could be applied to our code without any violation. If you see some rules, feel free to activate them.

  1. After you generate me reports to let me work on reasons to suppress, you can do

romani added a commit that referenced this issue Jul 11, 2017

romani added a commit that referenced this issue Jul 11, 2017

Issue #4681: commenting disablement of few inspections and fix for W3…
…CssValidation and UnusedCatchParameter

romani added a commit that referenced this issue Jul 11, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 11, 2017

Member

@Nimfadora , look at #4698, rebase after merge, it address the most huge in amount violations

Member

romani commented Jul 11, 2017

@Nimfadora , look at #4698, rebase after merge, it address the most huge in amount violations

romani added a commit that referenced this issue Jul 11, 2017

Issue #4681: commenting disablement of few inspections and fix for W3…
…CssValidation and UnusedCatchParameter
@Nimfadora

This comment has been minimized.

Show comment
Hide comment
@Nimfadora

Nimfadora Jul 11, 2017

Contributor

@romani here is the report on first part of undocumented violations
StringEquals
StringEqualsIgnoreCase
StringTokenizer
SuperTearDownInFinally
SuspiciousLiteralUnderscore
SuspiciousLocalesLanguages
SwitchStatement
SwitchStatementWithTooManyBranches
SynchronizationOnStaticField
SyntaxError
SystemExit
SystemOutErr
SystemProperties
TailRecursion
TestMethodWithoutAssertion
ThisEscapedInConstructor
ThreeNegationsPerMethod
ThrowCaughtLocally
TodoComment
TooBroadCatch
TrailingSpacesInProperty
TransientFieldNotInitialized
TryFinallyCanBeTryWithResources
TsLint
TypeMayBeWeakened
UncheckedExceptionClass
UnclearBinaryExpression
UnnecessaryDefault
UnnecessaryUnicodeEscape
UnusedProperty
UnusedReturnValue
UseOfAnotherObjectsPrivateField
UseOfPropertiesAsHashtable
UtilityClass
UtilityClassCanBeEnum
VarargParameter
VariableNotUsedInsideIf
VtlReferencesInspection
WeakerAccess
WrongPropertyKeyValueDelimiter
XmlHighlighting
XmlPathReference
XmlUnboundNsPrefix
unused

Contributor

Nimfadora commented Jul 11, 2017

@romani here is the report on first part of undocumented violations
StringEquals
StringEqualsIgnoreCase
StringTokenizer
SuperTearDownInFinally
SuspiciousLiteralUnderscore
SuspiciousLocalesLanguages
SwitchStatement
SwitchStatementWithTooManyBranches
SynchronizationOnStaticField
SyntaxError
SystemExit
SystemOutErr
SystemProperties
TailRecursion
TestMethodWithoutAssertion
ThisEscapedInConstructor
ThreeNegationsPerMethod
ThrowCaughtLocally
TodoComment
TooBroadCatch
TrailingSpacesInProperty
TransientFieldNotInitialized
TryFinallyCanBeTryWithResources
TsLint
TypeMayBeWeakened
UncheckedExceptionClass
UnclearBinaryExpression
UnnecessaryDefault
UnnecessaryUnicodeEscape
UnusedProperty
UnusedReturnValue
UseOfAnotherObjectsPrivateField
UseOfPropertiesAsHashtable
UtilityClass
UtilityClassCanBeEnum
VarargParameter
VariableNotUsedInsideIf
VtlReferencesInspection
WeakerAccess
WrongPropertyKeyValueDelimiter
XmlHighlighting
XmlPathReference
XmlUnboundNsPrefix
unused

@Nimfadora

This comment has been minimized.

Show comment
Hide comment
@Nimfadora

Nimfadora Jul 11, 2017

Contributor

@romani I also add links to the "till ..." report, so you can review it in more comfortable way

Contributor

Nimfadora commented Jul 11, 2017

@romani I also add links to the "till ..." report, so you can review it in more comfortable way

@Nimfadora

This comment has been minimized.

Show comment
Hide comment
@Nimfadora

Nimfadora Jul 11, 2017

Contributor

@romani UnnecessaryFinalOnLocalVariableOrParameter has 7904 violations,
UnqualifiedMethodAccess has 11547 violations should I send separate report on these violation?

Contributor

Nimfadora commented Jul 11, 2017

@romani UnnecessaryFinalOnLocalVariableOrParameter has 7904 violations,
UnqualifiedMethodAccess has 11547 violations should I send separate report on these violation?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 11, 2017

Member

UnnecessaryFinalOnLocalVariableOrParameter has 7904 violations, should I send separate report on this violation?

Suppress it as it conflicting with our FinalVariableCheck

Member

romani commented Jul 11, 2017

UnnecessaryFinalOnLocalVariableOrParameter has 7904 violations, should I send separate report on this violation?

Suppress it as it conflicting with our FinalVariableCheck

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jul 11, 2017

Member

UnnecessaryFinalOnLocalVariableOrParameter

Is there anyway to make it only do parameters and ignore variables?

Member

rnveach commented Jul 11, 2017

UnnecessaryFinalOnLocalVariableOrParameter

Is there anyway to make it only do parameters and ignore variables?

@Nimfadora

This comment has been minimized.

Show comment
Hide comment
@Nimfadora

Nimfadora Jul 11, 2017

Contributor

@romani UnqualifiedMethodAccess has 11547 violations and UnqualifiedStaticUsage has 4421 violations what should I do with it?

Contributor

Nimfadora commented Jul 11, 2017

@romani UnqualifiedMethodAccess has 11547 violations and UnqualifiedStaticUsage has 4421 violations what should I do with it?

@Nimfadora

This comment has been minimized.

Show comment
Hide comment
@Nimfadora

Nimfadora Jul 11, 2017

Contributor

@rnveach yes we can

Contributor

Nimfadora commented Jul 11, 2017

@rnveach yes we can

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jul 11, 2017

Member

Is there anyway to make it only do parameters and ignore variables?

yes we can

@Nimfadora @romani We should enable it this way then as we wanted to do something similar in sevntu by a custom check. See sevntu-checkstyle/sevntu.checkstyle#581 .
@Nimfadora Please give us the number of violations when only doing parameters.

Member

rnveach commented Jul 11, 2017

Is there anyway to make it only do parameters and ignore variables?

yes we can

@Nimfadora @romani We should enable it this way then as we wanted to do something similar in sevntu by a custom check. See sevntu-checkstyle/sevntu.checkstyle#581 .
@Nimfadora Please give us the number of violations when only doing parameters.

@Nimfadora

This comment has been minimized.

Show comment
Hide comment
@Nimfadora

Nimfadora Jul 11, 2017

Contributor

@rnveach we have 314 errors when ignoring variables. here is report

Contributor

Nimfadora commented Jul 11, 2017

@rnveach we have 314 errors when ignoring variables. here is report

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 11, 2017

Member

@Nimfadora ,

from https://nimfadora.github.io/idea/suppressed_first.html

Unbound XML namespace prefix inspection 14 warnings
XML highlighting inspection 127 errors

Suppress by "there is not xsd or DTD for ant files https://ant.apache.org/faq.html#dtd, some other config files also do not have schemes too"

TypeMayBeWeakened

suppress with comment "it blindly force all to most weak type even String should be CharSequence, we will follow that crazyness"

Unclear expression inspection

suppress, raise a lot of violations that make no sense to benefit from parentheses, like "a ==1 && b==2" force to use parentheses, that is not good

'switch' statement inspection

suppress "we like switch statements, we can not avoid usage of them"

Accessing a non‑public field of another object inspection 118 warnings

suppress "we like this style of accessing of content of inner classes, may be one day in future we change our mind"

'try finally' replaceable with 'try' with resources inspection 2 errors

suppress "we can not use try-with-resources till we switch to jacoco for code coverage"

JUnit test method without any assertions inspection 1265 errors

add BaseCheckTest.verify and other our verify method .
All other should be fixed.

Method with more than three negations inspection 59 errors

suppress "this inspection is not configurable, 3 it is too demanding, result code will not be better"

Reference checked for 'null' is not used inside 'if'

suppress, "using the same variable is not always required, especially in case where null is signal for action or break or ...."

Access of system properties inspection 27 errors

suppress, "we do not use system variables for any security relates reasons(no passwords or authentication or...)"

Declaration access can be weaker inspection 164 warnings

Should be updated to following, all other need to be resolved except for AbstractXxxxxxx classes.
violations in AbstractJavadocCheck should be suppressed, as such methods will be in use ones we make javadoc parser/Checks officially public to use by community.
In Abstract classes we can easily do "can be private", all other should be sent by PR for case by case processing.

  <inspection_tool class="WeakerAccess" enabled="true" level="WARNING" enabled_by_default="true">
    <scope name="Tests" level="WARNING" enabled="false">
      <option name="SUGGEST_PACKAGE_LOCAL_FOR_MEMBERS" value="false" />
      <option name="SUGGEST_PACKAGE_LOCAL_FOR_TOP_CLASSES" value="false" />
      <option name="SUGGEST_PRIVATE_FOR_INNERS" value="false" />
      <disabledExtension id="junit" />
    </scope>
    <option name="SUGGEST_PACKAGE_LOCAL_FOR_MEMBERS" value="false" />
    <option name="SUGGEST_PACKAGE_LOCAL_FOR_TOP_CLASSES" value="false" />
    <option name="SUGGEST_PRIVATE_FOR_INNERS" value="false" />
    <disabledExtension id="junit" />
  </inspection_tool>

Transient field is not initialized on deserialization

remove transient from declaration.

Synchronization on 'static' field inspection 2 errors

suppress by javadoc tag (in javadoc over the methods) that two cases, will be addressed at #4700

================================

fix and regenerate report after all are fixed.

Member

romani commented Jul 11, 2017

@Nimfadora ,

from https://nimfadora.github.io/idea/suppressed_first.html

Unbound XML namespace prefix inspection 14 warnings
XML highlighting inspection 127 errors

Suppress by "there is not xsd or DTD for ant files https://ant.apache.org/faq.html#dtd, some other config files also do not have schemes too"

TypeMayBeWeakened

suppress with comment "it blindly force all to most weak type even String should be CharSequence, we will follow that crazyness"

Unclear expression inspection

suppress, raise a lot of violations that make no sense to benefit from parentheses, like "a ==1 && b==2" force to use parentheses, that is not good

'switch' statement inspection

suppress "we like switch statements, we can not avoid usage of them"

Accessing a non‑public field of another object inspection 118 warnings

suppress "we like this style of accessing of content of inner classes, may be one day in future we change our mind"

'try finally' replaceable with 'try' with resources inspection 2 errors

suppress "we can not use try-with-resources till we switch to jacoco for code coverage"

JUnit test method without any assertions inspection 1265 errors

add BaseCheckTest.verify and other our verify method .
All other should be fixed.

Method with more than three negations inspection 59 errors

suppress "this inspection is not configurable, 3 it is too demanding, result code will not be better"

Reference checked for 'null' is not used inside 'if'

suppress, "using the same variable is not always required, especially in case where null is signal for action or break or ...."

Access of system properties inspection 27 errors

suppress, "we do not use system variables for any security relates reasons(no passwords or authentication or...)"

Declaration access can be weaker inspection 164 warnings

Should be updated to following, all other need to be resolved except for AbstractXxxxxxx classes.
violations in AbstractJavadocCheck should be suppressed, as such methods will be in use ones we make javadoc parser/Checks officially public to use by community.
In Abstract classes we can easily do "can be private", all other should be sent by PR for case by case processing.

  <inspection_tool class="WeakerAccess" enabled="true" level="WARNING" enabled_by_default="true">
    <scope name="Tests" level="WARNING" enabled="false">
      <option name="SUGGEST_PACKAGE_LOCAL_FOR_MEMBERS" value="false" />
      <option name="SUGGEST_PACKAGE_LOCAL_FOR_TOP_CLASSES" value="false" />
      <option name="SUGGEST_PRIVATE_FOR_INNERS" value="false" />
      <disabledExtension id="junit" />
    </scope>
    <option name="SUGGEST_PACKAGE_LOCAL_FOR_MEMBERS" value="false" />
    <option name="SUGGEST_PACKAGE_LOCAL_FOR_TOP_CLASSES" value="false" />
    <option name="SUGGEST_PRIVATE_FOR_INNERS" value="false" />
    <disabledExtension id="junit" />
  </inspection_tool>

Transient field is not initialized on deserialization

remove transient from declaration.

Synchronization on 'static' field inspection 2 errors

suppress by javadoc tag (in javadoc over the methods) that two cases, will be addressed at #4700

================================

fix and regenerate report after all are fixed.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 12, 2017

Member

Use of System.out or System.err inspection 9 error

Suppress by javadoc tag in Main class.

'switch' statement with too many branches inspection 11 errors

Try to change a limit to max value we have now, if not possible disable whole inspection "we like switch"

Unnecessary 'default' for enum 'switch' statement inspection 2

Try to change but might result in conflict with other tools, if so do disablement comment.

Member

romani commented Jul 12, 2017

Use of System.out or System.err inspection 9 error

Suppress by javadoc tag in Main class.

'switch' statement with too many branches inspection 11 errors

Try to change a limit to max value we have now, if not possible disable whole inspection "we like switch"

Unnecessary 'default' for enum 'switch' statement inspection 2

Try to change but might result in conflict with other tools, if so do disablement comment.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 14, 2017

Member

I experience extra violations(redundant suppression) in my IntelliJ 2017.1.4 in comparison TC (2017.1.2). Fix of them cause failure of TC, so IDEA version should be the same.
I did not find way to download the same version as TC, filed request https://teamcity-support.jetbrains.com/hc/en-us/requests/1036431

Member

romani commented Jul 14, 2017

I experience extra violations(redundant suppression) in my IntelliJ 2017.1.4 in comparison TC (2017.1.2). Fix of them cause failure of TC, so IDEA version should be the same.
I did not find way to download the same version as TC, filed request https://teamcity-support.jetbrains.com/hc/en-us/requests/1036431

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 18, 2017

Member

@Nimfadora , FYI

TC support replied to support request and uploaded to TC latest version of IDEA (2017.1.5) and I activated it in CI process, if you still experience different results of inspection validation it is recommended to upgrade IDEA to 2017.1.5.

Member

romani commented Jul 18, 2017

@Nimfadora , FYI

TC support replied to support request and uploaded to TC latest version of IDEA (2017.1.5) and I activated it in CI process, if you still experience different results of inspection validation it is recommended to upgrade IDEA to 2017.1.5.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 11, 2017

Member

@Nimfadora , not all disabled inspections are commented.
Each rule has to have comment.

$ grep -B1 "enabled=\"false\" level" config/intellij-idea-inspections.xml | grep "enabled=\"false\"" | wc -l
145
$ grep -B1 "enabled=\"false\" level" config/intellij-idea-inspections.xml | grep "\-\->" | wc -l
141

there should be no "till GSoC" comments or similar.

still need to be enabled:

$ grep -A2 "till GSoC" intellij-idea-inspections.xml | grep "enabled="
<inspection_tool class="AnonymousHasLambdaAlternative" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="Convert2MethodRef" enabled="false" level="ERROR" enabled_by_default="false" />
<inspection_tool class="Convert2streamapi" enabled="false" level="ERROR" enabled_by_default="false" />
<inspection_tool class="ConvertAnnotations" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="DuplicateAlternationBranch" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="DuplicateBooleanBranch" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="Java8MapApi" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="Java8MapForEach" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="JavaDoc" enabled="true" level="ERROR" enabled_by_default="true">
<inspection_tool class="OptionalIsPresent" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="OverloadedMethodsWithSameNumberOfParameters" enabled="true" level="WARNING" enabled_by_default="true">
<inspection_tool class="SimplifyStreamApiCallChains" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="SingleCharAlternation" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="SingleCharacterStartsWith" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="TooBroadScope" enabled="false" level="ERROR" enabled_by_default="false"/>
Member

romani commented Aug 11, 2017

@Nimfadora , not all disabled inspections are commented.
Each rule has to have comment.

$ grep -B1 "enabled=\"false\" level" config/intellij-idea-inspections.xml | grep "enabled=\"false\"" | wc -l
145
$ grep -B1 "enabled=\"false\" level" config/intellij-idea-inspections.xml | grep "\-\->" | wc -l
141

there should be no "till GSoC" comments or similar.

still need to be enabled:

$ grep -A2 "till GSoC" intellij-idea-inspections.xml | grep "enabled="
<inspection_tool class="AnonymousHasLambdaAlternative" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="Convert2MethodRef" enabled="false" level="ERROR" enabled_by_default="false" />
<inspection_tool class="Convert2streamapi" enabled="false" level="ERROR" enabled_by_default="false" />
<inspection_tool class="ConvertAnnotations" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="DuplicateAlternationBranch" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="DuplicateBooleanBranch" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="Java8MapApi" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="Java8MapForEach" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="JavaDoc" enabled="true" level="ERROR" enabled_by_default="true">
<inspection_tool class="OptionalIsPresent" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="OverloadedMethodsWithSameNumberOfParameters" enabled="true" level="WARNING" enabled_by_default="true">
<inspection_tool class="SimplifyStreamApiCallChains" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="SingleCharAlternation" enabled="false" level="WARNING" enabled_by_default="false" />
<inspection_tool class="SingleCharacterStartsWith" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="TooBroadScope" enabled="false" level="ERROR" enabled_by_default="false"/>
@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 22, 2017

Member

All works is done.
We end-up with 137 disabled inspections.

$ grep -B1 "enabled=\"false\" level" config/intellij-idea-inspections.xml | grep "enabled=\"false\"" | wc -l
137
$ grep -B1 "enabled=\"false\" level" config/intellij-idea-inspections.xml | grep "\-\->" | wc -l
137
Member

romani commented Aug 22, 2017

All works is done.
We end-up with 137 disabled inspections.

$ grep -B1 "enabled=\"false\" level" config/intellij-idea-inspections.xml | grep "enabled=\"false\"" | wc -l
137
$ grep -B1 "enabled=\"false\" level" config/intellij-idea-inspections.xml | grep "\-\->" | wc -l
137

@romani romani closed this Aug 22, 2017

@romani romani added this to the 8.2 milestone Aug 22, 2017

@romani romani moved this from In Progress to Done in Practice What You Preach Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment