New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find way to launch IntellijIdea inspections from command line #4682

Closed
romani opened this Issue Jul 9, 2017 · 8 comments

Comments

Projects
None yet
3 participants
@romani
Member

romani commented Jul 9, 2017

Each time TeamCity(TC) update IntellijIdea version we have problems on TC with different behavior of IntellijIdea on TC and on our local.
Execution in IntellijIdea require special configuration that users always forget ..... so TC catch such cases but they could be prevented.

It will be good to have shell script in our repo that takes path to IntelijIdea installation and to checkstyle sources and print validation to console or to a file.

TC do run inspections by command line, so we look how they do this, ..... inside IDEA installation where is ...../idea-IU-171.4249.39/bin/inspect.sh it might help too.

@romani romani added this to In Progress in Practice What You Preach Jul 9, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Aug 8, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Sep 1, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Sep 2, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Sep 3, 2017

romani added a commit that referenced this issue Sep 4, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Sep 4, 2017

Member

@Nimfadora ,

for linux:

  1. RESOLVED: On my local IDEA inspections give 2 group of violations:
target/inspection-results/RedundantSuppression.xml

it might be issues of my local IDEA.

  1. RESOLVED: on windows, from @rnveach :
    spaces in path does not work - #4922 (comment)

  2. on windows, from @rnveach :
    #4922 (comment)

  3. RESOLVED:
    idea_inspections.sh does not work with latest IDEA 2017.2.3 Community edition when it is just downloaded and unzipped. Workaround is launch its UI and import project ones to let Idea define JDK for project ... after such manual import , shell command works fine but report new violations - #5069 .
    There was such failure:

$ IDEA_PATH="/home/rivanov/java/temp/idea/idea-IC-172.3968.16/bin/idea.sh" ./.ci/idea_inspection.sh
Validation is about to start ... progress output will be flushed at end. Validation is in progress ...
The JDK is not configured properly for this project. Inspection cannot proceed.
1.8 not found
Member

romani commented Sep 4, 2017

@Nimfadora ,

for linux:

  1. RESOLVED: On my local IDEA inspections give 2 group of violations:
target/inspection-results/RedundantSuppression.xml

it might be issues of my local IDEA.

  1. RESOLVED: on windows, from @rnveach :
    spaces in path does not work - #4922 (comment)

  2. on windows, from @rnveach :
    #4922 (comment)

  3. RESOLVED:
    idea_inspections.sh does not work with latest IDEA 2017.2.3 Community edition when it is just downloaded and unzipped. Workaround is launch its UI and import project ones to let Idea define JDK for project ... after such manual import , shell command works fine but report new violations - #5069 .
    There was such failure:

$ IDEA_PATH="/home/rivanov/java/temp/idea/idea-IC-172.3968.16/bin/idea.sh" ./.ci/idea_inspection.sh
Validation is about to start ... progress output will be flushed at end. Validation is in progress ...
The JDK is not configured properly for this project. Inspection cannot proceed.
1.8 not found
@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Sep 4, 2017

Member

2 was fixed. It was an error of me not knowing the PATH has to be full location to bat file.

Is it better to be IDEA_BIN

I think this is better. We should change error message or add a comment to specify what we want it set to.

Member

rnveach commented Sep 4, 2017

2 was fixed. It was an error of me not knowing the PATH has to be full location to bat file.

Is it better to be IDEA_BIN

I think this is better. We should change error message or add a comment to specify what we want it set to.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Sep 4, 2017

Member

I think this is better.

@Nimfadora , please do for both versions of script.

Member

romani commented Sep 4, 2017

I think this is better.

@Nimfadora , please do for both versions of script.

romani added a commit that referenced this issue Sep 4, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Sep 4, 2017

Member

conifg/idea.properties was added to exclude(in TC web configuration) from IDEA validation to avoid UnusedProperty violation.
image

Member

romani commented Sep 4, 2017

conifg/idea.properties was added to exclude(in TC web configuration) from IDEA validation to avoid UnusedProperty violation.
image

romani added a commit that referenced this issue Sep 4, 2017

Issue #4682: remove extra configuration from idea_inspection.sh that …
…does not affect inspection to simplify script

romani added a commit that referenced this issue Sep 4, 2017

Issue #4682: rename idea.property to intellij-idea-inspections.proper…
…ties to all Idea file be grouped by same prefix

@romani romani added the miscellaneous label Sep 4, 2017

romani added a commit that referenced this issue Sep 4, 2017

Issue #4682: compilation has to be done before inspection execution t…
…o generate all sources and avoid multiple unexpected violations

romani added a commit that referenced this issue Sep 4, 2017

Issue #4682: remove exclude for RedundantSuppression, as it become wo…
…rk in my Idea after reimporting project. Fix scope file content.

romani added a commit that referenced this issue Sep 5, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Dec 5, 2017

Member

@romani Is this issue done? What is left to be done?

Member

rnveach commented Dec 5, 2017

@romani Is this issue done? What is left to be done?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Dec 13, 2017

Member

I remember that after summer there was update to IDEA that does not work any more for this shell.
So keep issue as reminder to recheck and update xdoc.

Member

romani commented Dec 13, 2017

I remember that after summer there was update to IDEA that does not work any more for this shell.
So keep issue as reminder to recheck and update xdoc.

@romani romani moved this from In Progress to To Do in Practice What You Preach Mar 11, 2018

@romani romani removed the GSoC2017 label Mar 11, 2018

@romani romani removed this from To Do in Practice What You Preach Mar 11, 2018

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 18, 2018

Member

It is required to recheck execution on latest 2017.2.x and 2017.3 , as it become works, we can close issue

Member

romani commented Mar 18, 2018

It is required to recheck execution on latest 2017.2.x and 2017.3 , as it become works, we can close issue

@romani romani added the CI label Mar 18, 2018

romani added a commit that referenced this issue May 9, 2018

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani May 9, 2018

Member

upgraded to 2017.2.6

Member

romani commented May 9, 2018

upgraded to 2017.2.6

@romani romani closed this May 9, 2018

@romani romani added this to the 8.11 milestone May 9, 2018

romani added a commit that referenced this issue May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment