Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make SuppressionCommentFilter and SuppressWithNearbyCommentFilter children of TreeWalker #4714
SuppressWithNearbyCommentFilter and SuppressionCommentFilter need to have information which can be extracted from AST. TreeWalker is the only one FileSetCheck which deals with AST. That is why it is reasonable to make both filters children of TreeWalker. AST must not be visible on the Checker level.
What should be done:
private String fileName; private FileContents fileContents; private LocalizedMessage localizedMessage;
We should not extend AuditEvent or create AbstractAuditEvent as we cannot design the whole model of events now. Thus, the concrete implementation is OK.
boolean accept(TreeWalkerAuditEvent auditEvent);
ATTENTION (config migration process):
This was referenced
Jul 13, 2017
No, they should be the children of TreeWalekr only.
No, they should implement AstFilter interface only.
As far as I know we should release Checkstyle with the changes made in the scope of this issue, change release Checkstyle version which is used by SevNTU Checkstyle, update SevNTU checkstyle version in main project, and change checkstyle_sevntu_checks.xml. Am I right?
yes, this is example of what other thirparty extensions should do to upgrade to latest version of checkstyle. We can not do all at ones, so we will need to disable sevntu for some time, till we release checkstyle 8.1 and next version of sevntu that is based on checkstyle 8.1 .