New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Handling for Javadoc Parsing #4717

Closed
ps-sp opened this Issue Jul 14, 2017 · 3 comments

Comments

3 participants
@ps-sp
Collaborator

ps-sp commented Jul 14, 2017

Right now when the errorListener object we implemented for ANTLR doesn't receive any errorMessage, we generate an uninformative ParseErrorMessage with key MSG_KEY_UNRECOGNIZED_ANTLR_ERROR leading to error messages like

[ERROR:0] Javadoc comment at column -3 has parse error. Unrecognized error from ANTLR parser: null

There is potential for adding custom error handling here and we can at least handle general cases if not all the cases and generate more informative error messages for the user.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 18, 2017

Member

@Vladlis , is it related to GSoC project

Member

romani commented Jul 18, 2017

@Vladlis , is it related to GSoC project

@Vladlis

This comment has been minimized.

Show comment
Hide comment
@Vladlis

Vladlis Jul 18, 2017

Member

@romani , it is, but priority is low, so we can work on it if we have time in the end

Member

Vladlis commented Jul 18, 2017

@romani , it is, but priority is low, so we can work on it if we have time in the end

ps-sp added a commit to ps-sp/checkstyle that referenced this issue Jul 25, 2017

ps-sp added a commit to ps-sp/checkstyle that referenced this issue Jul 25, 2017

@Vladlis Vladlis added the GSoC2017 label Jul 26, 2017

ps-sp added a commit to ps-sp/checkstyle that referenced this issue Jul 26, 2017

ps-sp added a commit to ps-sp/checkstyle that referenced this issue Jul 26, 2017

ps-sp added a commit to ps-sp/checkstyle that referenced this issue Jul 26, 2017

ps-sp added a commit to ps-sp/checkstyle that referenced this issue Jul 27, 2017

Vladlis added a commit that referenced this issue Jul 28, 2017

@Vladlis

This comment has been minimized.

Show comment
Hide comment
@Vladlis

Vladlis Jul 28, 2017

Member

fix is merged

Member

Vladlis commented Jul 28, 2017

fix is merged

@Vladlis Vladlis closed this Jul 28, 2017

@Vladlis Vladlis added this to the 8.2 milestone Jul 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment