New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage of JavadocParser and JavadocLexer #4769

Open
Vladlis opened this Issue Jul 19, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@Vladlis
Member

Vladlis commented Jul 19, 2017

JavadocParser and JavadocLexer are classes generated by ANTLR. We need to cover them by UTs as much as possible to validate javadoc grammar.

GSoC priority is low as we need to focus on functional changes first. But coverage should only increase by each PR.

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Jul 19, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Jul 20, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Jul 20, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Jul 20, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Jul 20, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Jul 20, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Jul 20, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Jul 20, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Jul 20, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Jul 21, 2017

romani added a commit that referenced this issue Jul 21, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 21, 2017

Member

@ps-sp ,
initial commit is merged and set minimal/current state of coverage.
please rebase your PRs over our master to make sure that coverage is lowered.
As you are going to change grammar please make sure that in each PR you slightly increase coverage and numbers of coverage should be increased in almost each PR (each PR is expected to change pom.xml cobertura configuration).

Member

romani commented Jul 21, 2017

@ps-sp ,
initial commit is merged and set minimal/current state of coverage.
please rebase your PRs over our master to make sure that coverage is lowered.
As you are going to change grammar please make sure that in each PR you slightly increase coverage and numbers of coverage should be increased in almost each PR (each PR is expected to change pom.xml cobertura configuration).

@ps-sp

This comment has been minimized.

Show comment
Hide comment
@ps-sp

ps-sp Jul 22, 2017

Collaborator

@romani ok

Collaborator

ps-sp commented Jul 22, 2017

@romani ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment