New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DetailNodeTreeStringPrinter#createFakeBlockComment to CommonUtils #4785

Closed
ps-sp opened this Issue Jul 20, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@ps-sp
Collaborator

ps-sp commented Jul 20, 2017

Method DetailNodeTreeStringPrinter#createFakeBlockComment should be moved to CommonUtils and TreeWalker#createBlockCommentNode should be replaced with the new method(s) created in CommonUtils.

@magicimagination

This comment has been minimized.

Show comment
Hide comment
@magicimagination

magicimagination Oct 12, 2017

Contributor

@romani @ps-sp Why instead createBlockCommentNode() should be used new methods from JavadocUtils? Comments are related not always necessary with Javadoc.

Contributor

magicimagination commented Oct 12, 2017

@romani @ps-sp Why instead createBlockCommentNode() should be used new methods from JavadocUtils? Comments are related not always necessary with Javadoc.

@romani romani changed the title from Move DetailNodeTreeStringPrinter#createFakeBlockComment to JavadocUtils to Move DetailNodeTreeStringPrinter#createFakeBlockComment to CommonUtils Oct 12, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Oct 12, 2017

Member

@magicimagination , good point.

Lets move this method to CommonUtils, creation of CommentUtils is not reasonable now as there is only one method for now.
I updated issue title and issue description.

Member

romani commented Oct 12, 2017

@magicimagination , good point.

Lets move this method to CommonUtils, creation of CommentUtils is not reasonable now as there is only one method for now.
I updated issue title and issue description.

magicimagination added a commit to epam/checkstyle that referenced this issue Oct 13, 2017

magicimagination added a commit to epam/checkstyle that referenced this issue Oct 16, 2017

magicimagination added a commit to epam/checkstyle that referenced this issue Oct 16, 2017

magicimagination added a commit to epam/checkstyle that referenced this issue Oct 18, 2017

magicimagination added a commit to epam/checkstyle that referenced this issue Oct 18, 2017

magicimagination added a commit to epam/checkstyle that referenced this issue Oct 18, 2017

magicimagination added a commit to epam/checkstyle that referenced this issue Oct 18, 2017

magicimagination added a commit to epam/checkstyle that referenced this issue Oct 19, 2017

magicimagination added a commit to epam/checkstyle that referenced this issue Oct 19, 2017

magicimagination added a commit to epam/checkstyle that referenced this issue Oct 20, 2017

magicimagination added a commit to epam/checkstyle that referenced this issue Oct 20, 2017

magicimagination added a commit to epam/checkstyle that referenced this issue Oct 20, 2017

magicimagination added a commit to epam/checkstyle that referenced this issue Oct 20, 2017

romani added a commit that referenced this issue Oct 20, 2017

@romani romani added this to the 8.4 milestone Oct 20, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Oct 20, 2017

Member

Fix I'd merged

Member

romani commented Oct 20, 2017

Fix I'd merged

@romani romani closed this Oct 20, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment