New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: eleventh part of idea violations #4801

Closed
Nimfadora opened this Issue Jul 23, 2017 · 3 comments

Comments

Projects
2 participants
@Nimfadora
Contributor

Nimfadora commented Jul 23, 2017

sub-task of #4681

review is available here

Violations included:

fixed:
XmlUnboundNsPrefix
XmlHighlighting
UnclearBinaryExpression
SwitchStatement
UseOfAnotherObjectsPrivateField
TryFinallyCanBeTryWithResources
ThreeNegationsPerMethod
VariableNotUsedInsideIf
SystemProperties
SwitchStatementWithTooManyBranches
StringEquals
StringEqualsIgnoreCase
SuperTearDownInFinally
SuspiciousLiteralUnderscore
SuspiciousLocalesLanguages
SyntaxError
TailRecursion
ThrowCaughtLocally
TrailingSpacesInProperty
UnnecessaryUnicodeEscape
WrongPropertyKeyValueDelimiter
TransientFieldNotInitialized
SynchronizationOnStaticField
UnnecessaryDefault
TestMethodWithoutAssertion
UnusedReturnValue
unused
TooBroadCatch
UncheckedExceptionClass
UnusedProperty
TodoComment
ThisEscapedInConstructor
StringTokenizer
VarargParameter
SystemExit
UseOfPropertiesAsHashtable
UnnecessaryFinalOnLocalVariableOrParameter
XmlPathReference
WeakerAccess

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 23, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 23, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 23, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 23, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 23, 2017

romani added a commit that referenced this issue Jul 23, 2017

@romani romani modified the milestone: 8.1 Jul 23, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 24, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 25, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 25, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 25, 2017

Nimfadora pushed a commit to Nimfadora/checkstyle that referenced this issue Jul 26, 2017

romani added a commit that referenced this issue Jul 26, 2017

@romani romani added this to In Progress in Practice What You Preach Jul 27, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 27, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 27, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 29, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 31, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 31, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 31, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 31, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 31, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 31, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Jul 31, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Aug 7, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Aug 7, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Aug 7, 2017

romani added a commit that referenced this issue Aug 9, 2017

romani added a commit that referenced this issue Aug 9, 2017

romani added a commit that referenced this issue Aug 9, 2017

romani added a commit that referenced this issue Aug 9, 2017

romani added a commit that referenced this issue Aug 10, 2017

romani added a commit that referenced this issue Aug 10, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 10, 2017

Member

@Nimfadora , WeakerAccess fix is merged.
Please proceed with other inspections.

Member

romani commented Aug 10, 2017

@Nimfadora , WeakerAccess fix is merged.
Please proceed with other inspections.

@Nimfadora

This comment has been minimized.

Show comment
Hide comment
@Nimfadora

Nimfadora Aug 10, 2017

Contributor

@romani if WeakerAccess is fully resolved, than this task may be closed. All violations are fixed.

Contributor

Nimfadora commented Aug 10, 2017

@romani if WeakerAccess is fully resolved, than this task may be closed. All violations are fixed.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 11, 2017

Member

ok, I am closing this issue

Member

romani commented Aug 11, 2017

ok, I am closing this issue

@romani romani closed this Aug 11, 2017

@romani romani added this to the 8.2 milestone Aug 11, 2017

@romani romani moved this from In Progress to Done in Practice What You Preach Aug 11, 2017

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

soon added a commit to soon/checkstyle that referenced this issue Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment