New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeWalkerFilter needs to be added to ModuleReflectionUtils #4843

Closed
rnveach opened this Issue Jul 28, 2017 · 3 comments

Comments

4 participants
@rnveach
Member

rnveach commented Jul 28, 2017

We identify everything inside ModuleReflectionUtils.
However, we didn't add TreeWalkerFilter to it, so it will never be recognized as one of our modules.

It must be added to ModuleReflectionUtils and verified it is picked up everywhere.
Without it listed, we will have bugs similar to #4742.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach
Member

rnveach commented Jul 28, 2017

@MEZk @timurt ping

@rnveach rnveach added the approved label Jul 28, 2017

@MEZk

This comment has been minimized.

Show comment
Hide comment
@MEZk

MEZk Jul 29, 2017

Contributor

@rnveach
Yes, should be fixed.

@timurt
Please, send PR.

Contributor

MEZk commented Jul 29, 2017

@rnveach
Yes, should be fixed.

@timurt
Please, send PR.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 31, 2017

Member

fix is merged.

Member

romani commented Jul 31, 2017

fix is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment