New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve IDEA inspection BooleanParameter in AbstractModuleTestSupport.createChecker #4857

Closed
romani opened this Issue Jul 30, 2017 · 4 comments

Comments

Projects
3 participants
@romani
Member

romani commented Jul 30, 2017

hot fix - 1b7f820

need to be resolved.

@Nimfadora , please take a look.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Aug 2, 2017

Member

@Nimfadora Can you also resolve the new boolean added to https://github.com/checkstyle/checkstyle/blob/master/src/it/java/com/google/checkstyle/test/base/AbstractModuleTestSupport.java#L136 in this issue too?
It is a mirror of the PR you are already doing.

Member

rnveach commented Aug 2, 2017

@Nimfadora Can you also resolve the new boolean added to https://github.com/checkstyle/checkstyle/blob/master/src/it/java/com/google/checkstyle/test/base/AbstractModuleTestSupport.java#L136 in this issue too?
It is a mirror of the PR you are already doing.

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Aug 7, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Aug 7, 2017

romani added a commit that referenced this issue Aug 8, 2017

@romani romani added this to the 8.2 milestone Aug 8, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 8, 2017

Member

fix is merged

Member

romani commented Aug 8, 2017

fix is merged

@romani romani closed this Aug 8, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Aug 8, 2017

Member

@romani Look at comment #4857 (comment) , IT area was not fixed yet. It still has suppression.

Member

rnveach commented Aug 8, 2017

@romani Look at comment #4857 (comment) , IT area was not fixed yet. It still has suppression.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 17, 2017

Member

@Nimfadora , please resolve issue in IT area.

Member

romani commented Aug 17, 2017

@Nimfadora , please resolve issue in IT area.

@romani romani moved this from Done to In Progress in Practice What You Preach Aug 17, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Aug 19, 2017

romani added a commit that referenced this issue Aug 19, 2017

@romani romani closed this Aug 19, 2017

@romani romani moved this from In Progress to Done in Practice What You Preach Aug 22, 2017

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

soon added a commit to soon/checkstyle that referenced this issue Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment