New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: fix ThisEscapedInConstructor idea violation for ImportControl class #4863

Closed
Nimfadora opened this Issue Jul 31, 2017 · 4 comments

Comments

Projects
2 participants
@Nimfadora
Contributor

Nimfadora commented Jul 31, 2017

sub-task of #4681

fix 'this' reference escaped in object construction for ImportControl class

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 11, 2017

Member

@Nimfadora , this should be addressed during this summer.
code should be like:

newItem = new ImportControl()
parent.addChild(newItem)
Member

romani commented Aug 11, 2017

@Nimfadora , this should be addressed during this summer.
code should be like:

newItem = new ImportControl()
parent.addChild(newItem)
@Nimfadora

This comment has been minimized.

Show comment
Hide comment
@Nimfadora

Nimfadora Aug 12, 2017

Contributor

@romani if we do like this than we create such situation:
this.parent = parent
parent.child = newItem
newItem != this

Contributor

Nimfadora commented Aug 12, 2017

@romani if we do like this than we create such situation:
this.parent = parent
parent.child = newItem
newItem != this

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 17, 2017

Member

@Nimfadora , I did atypo in my comment, please review.
Code should be fixed.

Member

romani commented Aug 17, 2017

@Nimfadora , I did atypo in my comment, please review.
Code should be fixed.

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Aug 17, 2017

Nimfadora added a commit to Nimfadora/checkstyle that referenced this issue Aug 19, 2017

romani added a commit that referenced this issue Aug 20, 2017

@romani romani added this to the 8.2 milestone Aug 20, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 20, 2017

Member

Fix is merged

Member

romani commented Aug 20, 2017

Fix is merged

@romani romani closed this Aug 20, 2017

@romani romani moved this from To Do to Done in Practice What You Preach Aug 22, 2017

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment