Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring of DetailASTTest.testTreeStructure #4900

Closed
romani opened this issue Aug 4, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@romani
Copy link
Member

commented Aug 4, 2017

https://github.com/checkstyle/checkstyle/blob/master/src/test/java/com/puppycrawl/tools/checkstyle/api/DetailASTTest.java#L244

PMD and inspection suppressions should be resolved.

test method should be named testTreeStructureOnAllInputFiles
test method should become like:

getAllFiles();
FOR (file: allFiles) {
  root = parse(file)
  traverse(file, root, new CallBackOnNode() {
   // content of checkNode method
   }
  );
}

Issue is taken from discussion at #4880 about extra suppression of PMD.

@romani

This comment has been minimized.

Copy link
Member Author

commented May 19, 2019

fix is merged.

@romani romani closed this May 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.