New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thread-unsafe context from the AbstractFileSetCheck class #4917

Closed
soon opened this Issue Aug 9, 2017 · 1 comment

Comments

@soon
Contributor

soon commented Aug 9, 2017

Now the AbstractFileSetCheck class contains some thread-unsafe context, therefore we cannot use the same check instance across multiple threads.

All thread-unsafe members should be rewritten so that they could be used from the separate threads:

messageCollector - it is updated inside process method and via addMessages and other methods.

soon added a commit to soon/checkstyle that referenced this issue Aug 9, 2017

@romani romani changed the title from Remove thread-unsafe context from the `AbstractFileSetCheck` class to Remove thread-unsafe context from the AbstractFileSetCheck class Aug 17, 2017

soon added a commit to soon/checkstyle that referenced this issue Sep 17, 2017

soon added a commit to soon/checkstyle that referenced this issue Sep 17, 2017

soon added a commit to soon/checkstyle that referenced this issue Sep 17, 2017

soon added a commit to soon/checkstyle that referenced this issue Sep 21, 2017

soon added a commit to soon/checkstyle that referenced this issue Sep 21, 2017

romani added a commit that referenced this issue Sep 23, 2017

@romani romani added this to the 8.3 milestone Sep 23, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Sep 23, 2017

Member

fix is merged

Member

romani commented Sep 23, 2017

fix is merged

@romani romani closed this Sep 23, 2017

djydewang added a commit to djydewang/checkstyle that referenced this issue Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment