New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thread-unsafe context from the AbstractJavadocCheck class #4925

Closed
soon opened this Issue Aug 10, 2017 · 1 comment

Comments

@soon
Contributor

soon commented Aug 10, 2017

Now the AbstractJavadocCheck class contains some thread-unsafe context, therefore we cannot use the same check instance across multiple threads.

All thread-unsafe members should be rewritten so that they could be used from the separate threads:

  1. parser - the JavadocDetailNodeParser isn't a thread-safe class
  2. blockCommentAst - the AbstractJavadocCheck updates this field in the visitToken method

soon added a commit to soon/checkstyle that referenced this issue Aug 10, 2017

soon added a commit to soon/checkstyle that referenced this issue Aug 10, 2017

@Vladlis Vladlis added the approved label Aug 10, 2017

@Vladlis Vladlis added the GSoC2017 label Aug 10, 2017

@sabaka sabaka moved this from In Progress to In Review in Multi-thread mode for Java files processing Aug 14, 2017

@romani romani changed the title from Remove thread-unsafe context from the `AbstractJavadocCheck` class to Remove thread-unsafe context from the AbstractJavadocCheck class Aug 17, 2017

@romani romani added the bug label Aug 17, 2017

romani added a commit that referenced this issue Aug 17, 2017

@romani romani added this to the 8.2 milestone Aug 17, 2017

@sabaka sabaka moved this from In Review to Done in Multi-thread mode for Java files processing Aug 18, 2017

@sabaka

This comment has been minimized.

Show comment
Hide comment
@sabaka

sabaka Aug 18, 2017

Contributor

merged

Contributor

sabaka commented Aug 18, 2017

merged

@sabaka sabaka closed this Aug 18, 2017

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment