New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavadocPackageCheck should be thread-safe #4945

Closed
soon opened this Issue Aug 14, 2017 · 1 comment

Comments

@soon
Contributor

soon commented Aug 14, 2017

The JavadocPackageCheck contains a field directoriesChecked, which contains all processed directories.

This field should be updated across the application lifetime (https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocPackageCheck.java#L73), therefore it should be thread-safe

soon added a commit to soon/checkstyle that referenced this issue Aug 14, 2017

soon added a commit to soon/checkstyle that referenced this issue Aug 14, 2017

romani added a commit that referenced this issue Aug 17, 2017

@romani romani changed the title from `JavadocPackageCheck` should be thread-safe to JavadocPackageCheck should be thread-safe Aug 17, 2017

@romani romani added the bug label Aug 17, 2017

@romani romani added this to the 8.2 milestone Aug 17, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 17, 2017

Member

fix is merged

Member

romani commented Aug 17, 2017

fix is merged

@romani romani closed this Aug 17, 2017

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment