New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add columnCharIndex field to LocalizedMessage #4998

Closed
MEZk opened this Issue Aug 24, 2017 · 2 comments

Comments

@MEZk
Contributor

MEZk commented Aug 24, 2017

The log method of AbstractCheck stores shifted column number (with expanded tabs) to the LocalizedMessage. This column number cannot be used in XpathFilter as the token with that columnNo might not exist in the tree.

For example, if there is a tab character on line 1, the ANTLR parser will return the token with the columnNo=1, but Checkstyle will print 4 as a columnNo in the violation.

Thus, we need to store the real column number to localized message.

@MEZk MEZk moved this from To Do to In Progress in Flexible Suppression Model Aug 24, 2017

@MEZk

This comment has been minimized.

Show comment
Hide comment
@MEZk

MEZk Aug 27, 2017

Contributor

@timurt
Did you start working on this issue?

Contributor

MEZk commented Aug 27, 2017

@timurt
Did you start working on this issue?

timurt pushed a commit to timurt/checkstyle that referenced this issue Aug 29, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Aug 30, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Aug 31, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Aug 31, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Sep 1, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Sep 2, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Sep 4, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Sep 5, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Sep 5, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Sep 5, 2017

romani added a commit that referenced this issue Sep 6, 2017

@romani romani added the new feature label Sep 6, 2017

@romani romani added this to the 8.3 milestone Sep 6, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Sep 6, 2017

Member

fix is merged

Member

romani commented Sep 6, 2017

fix is merged

@romani romani closed this Sep 6, 2017

@MEZk MEZk moved this from In Progress to Done in Flexible Suppression Model Sep 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment