New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add violateExecutionOnNonTightHtml property of AbstractJavadocCheck to xdoc #5002

Closed
Vladlis opened this Issue Aug 25, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@Vladlis
Member

Vladlis commented Aug 25, 2017

As a result of #3311 a new property violateExecutionOnNonTightHtml is added to AbstractJavadocCheck. This property has to be added to xdoc.

Tip: https://github.com/checkstyle/checkstyle/pull/4751/files#r134985454

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Dec 5, 2017

Member

@romani I noticed we didn't turn on violateExecutionOnNonTightHtml for any of our checks in our configuration. Should we do this in a new issue?

Member

rnveach commented Dec 5, 2017

@romani I noticed we didn't turn on violateExecutionOnNonTightHtml for any of our checks in our configuration. Should we do this in a new issue?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Dec 5, 2017

Member

Should we do this in a new issue?

I think we do not need this, as all our current validations are not that HTML related.
If you know cases where we should start to fail - please create new issue.

Member

romani commented Dec 5, 2017

Should we do this in a new issue?

I think we do not need this, as all our current validations are not that HTML related.
If you know cases where we should start to fail - please create new issue.

rnveach added a commit that referenced this issue Dec 6, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Dec 6, 2017

Member

Fix was merged.

Member

rnveach commented Dec 6, 2017

Fix was merged.

@rnveach rnveach closed this Dec 6, 2017

@rnveach rnveach added this to the 8.6 milestone Dec 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment