New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit the usage of hardcoded encoding in Checkstyle source code #5023

Closed
MEZk opened this Issue Aug 29, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@MEZk
Contributor

MEZk commented Aug 29, 2017

We need to use http://checkstyle.sourceforge.net/config_coding.html#IllegalTokenText to prohibit the usage of hardcoded encoding in Checkstyle source code to avoid code like this:

new FileText(new File(fileName), System.getProperty("file.encoding", "UTF-8"));

We need to force the contributors to use StandardCharsets.

@AADudkin

This comment has been minimized.

Show comment
Hide comment
@AADudkin

AADudkin commented Oct 11, 2017

I'm on it

AADudkin pushed a commit to epam/checkstyle that referenced this issue Oct 16, 2017

AADudkin pushed a commit to epam/checkstyle that referenced this issue Oct 16, 2017

romani added a commit that referenced this issue Oct 18, 2017

@romani romani added this to the 8.4 milestone Oct 18, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Oct 18, 2017

Member

fix is merged.

Member

romani commented Oct 18, 2017

fix is merged.

@romani romani closed this Oct 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment