Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
TranslationCheck: should fire file started/finished when invoking errors #5057
Identified at #5043 (comment) this issue is slightly related to multi-file validation,
PR wishes to remove file started/finished calls in
As pitest has proven these calls aren't needed because:
and the XML logger clears out it's file cache if it hadn't before.
So correct output is still here only because XML logger was extra careful in clearing out it's cache.
DefaultLogger doesn't care about files starting or finishing really.
To me, it is weird we fire errors without a start/end file, but this check is already 'special' as it is related to multi-file mode. We can't assume any new listener made will know this weird behavior.
I suggest we undo the changes to