New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review disabled validations of eclipse compiler #5060

Open
romani opened this Issue Sep 2, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@romani
Member

romani commented Sep 2, 2017

continuation of #2600.

command for linux:
mvn clean compile exec:exec -Peclipse-compiler

Disabled validations:

org.eclipse.jdt.core.compiler.annotation.missingNonNullByDefaultAnnotation=ignore
org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=ignore
org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore
org.eclipse.jdt.core.compiler.problem.rawTypeReference=ignore
org.eclipse.jdt.core.compiler.problem.reportMethodCanBePotentiallyStatic=ignore
org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=ignore
org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore
org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=ignore
org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore

review each of them and make a decision to fix or keep disabled.
Each disabled rule should have comment above to explain a reason.

@romani romani added the approved label Sep 2, 2017

romani added a commit that referenced this issue Sep 2, 2017

Issue #5060: activate rules that cause no error, place comment to sup…
…port suppression to eclipse validation properties

@romani romani added the miscellaneous label Sep 2, 2017

romani added a commit that referenced this issue Sep 2, 2017

romani added a commit that referenced this issue Sep 2, 2017

@romani romani removed this from To Do in Practice What You Preach Mar 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment