Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Expand eclipse compiler to check test code #5116
Identified at #5113 ,
When I enable these settings in Eclipse IDE, they automatically apply them to testso I still see errors in our configuration. I think we should update our CI to include test. This results in 24 errors, most of which need to just be suppressed as they are ways of testing.
Here is the list:
Like I said, as it is right now with checkstyle's eclipse file in the IDE, I am getting errors all over the test code. Eclipse doesn't have an ability to suppress things another way unless they added something in newer IDEs. You also can't separate out different
Another idea is to fool it's validation by using reflection to call the constructor just for test so we are hiding that the allocation occurs.
please send fix to "ignore" such rules to let this actually work, the same as in Eclipse - it is critical point.
I personally do not like some violations that are not critical to fix to pass build, nobody fix them and they only accumulate and pollute code, hide other problems .... .
if Eclipse does not have any other suppression, I have never seen any except for annotation. .... I rejected to all static analysis tool to use annotations, even for IDEA, not sure we can allow this now.