Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove usage of DetailAST.branchContains #5124
Identified at #4727 (comment) ,
The referenced issue fixed a bug where we used
There may be other cases in our code where it might be searching too much.
Because we are doing a
We should swap it's current uses with either
this method just do search in tree, nothing related to any logic of any Check.
user can launch this method of root and receive even more interesting results, that probably not up to its expectations.
This looks like just simple mis-usage of some method by engineer.
Please share more points to support removal of it.
@romani I will check again, but when I looked the majority of cases where calling the method on modifiers looking for static/public/etc... Unless we can define those modifiers inside or on an annotation, I don't think there are other cases to support.
I still think it should be removed because it's use case will be rare.
@romani It can't really go outside the AST class because it has to build up all the children trees recursively and cache them through