New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix violations from new sevntu check - CheckstyleTestMakeupCheck #5228

Closed
rnveach opened this Issue Oct 24, 2017 · 4 comments

Comments

2 participants
@rnveach
Member

rnveach commented Oct 24, 2017

Fix violations found by new sevntu check at sevntu-checkstyle/sevntu.checkstyle#610 .

rnveach added a commit to rnveach/checkstyle that referenced this issue Oct 24, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Oct 24, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Oct 24, 2017

romani added a commit that referenced this issue Oct 26, 2017

romani added a commit that referenced this issue Oct 26, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Oct 26, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Oct 26, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Oct 26, 2017

romani added a commit that referenced this issue Oct 27, 2017

romani added a commit that referenced this issue Oct 28, 2017

@rnveach rnveach added this to In Progress in Regression Testing Tool Oct 30, 2017

@rnveach rnveach added the GSoC2017 label Oct 30, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Nov 18, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Nov 18, 2017

romani added a commit that referenced this issue Nov 18, 2017

romani added a commit that referenced this issue Nov 18, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Nov 19, 2017

Member

All changes were merged. I think we should keep this open until new check is merged.

Member

rnveach commented Nov 19, 2017

All changes were merged. I think we should keep this open until new check is merged.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Nov 25, 2017

Member

@romani Once sevntu is released and new check is added, this issue can be closed.

Member

rnveach commented Nov 25, 2017

@romani Once sevntu is released and new check is added, this issue can be closed.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Nov 26, 2017

Member

@rnveach

done - http://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.25.0

please proceed,

  1. please activate all new Checks.
  2. update https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/gh-pages/sevntu-checkstyle-default-configuration.xml to contains default configuration WITH ALL PROPERTIES WITH DEFAULT VALUES for new Checks (it is used for Sonar and Ant configuration samples) (this is required step from https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/How-to-release-sevntu.checkstyle)
Member

romani commented Nov 26, 2017

@rnveach

done - http://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.25.0

please proceed,

  1. please activate all new Checks.
  2. update https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/gh-pages/sevntu-checkstyle-default-configuration.xml to contains default configuration WITH ALL PROPERTIES WITH DEFAULT VALUES for new Checks (it is used for Sonar and Ant configuration samples) (this is required step from https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/How-to-release-sevntu.checkstyle)
@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Nov 26, 2017

Member

fix is merged

Member

romani commented Nov 26, 2017

fix is merged

@romani romani closed this Nov 26, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Dec 19, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Dec 19, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Dec 19, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Dec 19, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Dec 19, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Dec 19, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment