New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plural agreement grammar in documentation for DesignForExtension #5249

Closed
Dispader opened this Issue Nov 6, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@Dispader
Contributor

Dispader commented Nov 6, 2017

The (most excellent) DesignForExtension documentation has minor grammatical errors involving plural agreement in two places.

  1. DesignForExtensionCheck.java
    • reads "makes sense only for library projects (not an application projects)"
      • "an application projects" disagrees
  2. xdocs/config_design.xml
    • reads "makes sense only for library project (not an application projects)"
      • "for library project" mismatches the JavaDoc, and disagrees
      • "an application projects" disagrees

Dispader added a commit to Dispader/checkstyle that referenced this issue Nov 6, 2017

romani added a commit that referenced this issue Nov 7, 2017

@romani romani added this to the 8.5 milestone Nov 7, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Nov 7, 2017

Member

fix is merged

Member

romani commented Nov 7, 2017

fix is merged

@romani romani closed this Nov 7, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment