New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cobertura coverage check failing on jdk 152 #5283

Closed
romani opened this Issue Nov 22, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@romani
Member

romani commented Nov 22, 2017

noticed on appveyor:
success - java version "1.8.0_144" https://ci.appveyor.com/project/Checkstyle/checkstyle/build/10229/job/xoh2k6sa6radqcp7#L32
failure - java version "1.8.0_152" - https://ci.appveyor.com/project/Checkstyle/checkstyle/build/10230/job/5ju0fkpi6fi3enna#L29

reproducible on linux too:

$ java -version
java version "1.8.0_152"
Java(TM) SE Runtime Environment (build 1.8.0_152-b16)
Java HotSpot(TM) 64-Bit Server VM (build 25.152-b16, mixed mode)

$ git diff
diff --git a/pom.xml b/pom.xml
index 81c29cf..f194ad3 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1569,7 +1569,7 @@
             <artifactId>cobertura-maven-plugin</artifactId>
             <version>2.7</version>
             <configuration>
-              <quiet>true</quiet>
+              <!--<quiet>true</quiet>-->
               <formats>
                 <format>xml</format>
                 <format>html</format>

$ mvn clean verify
....
[INFO] --- cobertura-maven-plugin:2.7:check (default) @ checkstyle ---
[INFO] Cobertura 2.1.1 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file
[INFO] Cobertura: Loaded information on 429 classes.
[ERROR] com.puppycrawl.tools.checkstyle.utils.FilterUtils failed coverage check. Line coverage rate of 93.7% is below 100.0%

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE

image

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Nov 23, 2017

Member

reason is described at cobertura/cobertura#170

Member

romani commented Nov 23, 2017

reason is described at cobertura/cobertura#170

romani added a commit that referenced this issue Nov 23, 2017

romani added a commit that referenced this issue Nov 23, 2017

@romani romani added this to the 8.5 milestone Nov 23, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Nov 23, 2017

Member

Fix is merged

Member

romani commented Nov 23, 2017

Fix is merged

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Nov 23, 2017

Member

@romani appveyor fix is now causing shippable failure.
https://app.shippable.com/github/checkstyle/checkstyle/runs/5579/22/console

Survived items:target/pit-reports/201711230247/com.puppycrawl.tools.checkstyle.utils/FilterUtils.java.html:<td class='survived'> target/pit-reports/201711230247/com.puppycrawl.tools.checkstyle.utils/FilterUtils.java.html:<td class='covered'><pre><span class='survived'> suppressionSourceExists = suppressionSourceExists &#38;&#38; closed;</span></pre></td></tr>
Survived items found in reports, build will be failed

Member

rnveach commented Nov 23, 2017

@romani appveyor fix is now causing shippable failure.
https://app.shippable.com/github/checkstyle/checkstyle/runs/5579/22/console

Survived items:target/pit-reports/201711230247/com.puppycrawl.tools.checkstyle.utils/FilterUtils.java.html:<td class='survived'> target/pit-reports/201711230247/com.puppycrawl.tools.checkstyle.utils/FilterUtils.java.html:<td class='covered'><pre><span class='survived'> suppressionSourceExists = suppressionSourceExists &#38;&#38; closed;</span></pre></td></tr>
Survived items found in reports, build will be failed

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Nov 23, 2017

Member

@romani The reason why shippable didn't fail in your PR is because nothing ran.
See https://app.shippable.com/github/checkstyle/checkstyle/runs/5576/summary/console
Everything says less than 1 minute and there is no printout for each job. Something triggered shippable to skip running.

Member

rnveach commented Nov 23, 2017

@romani The reason why shippable didn't fail in your PR is because nothing ran.
See https://app.shippable.com/github/checkstyle/checkstyle/runs/5576/summary/console
Everything says less than 1 minute and there is no printout for each job. Something triggered shippable to skip running.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Nov 24, 2017

Member

Something triggered shippable to skip running.

in all linux CIs we have SKIP_CI variable to skip execution while we debuging certain CI, so it skips execution if change only in other ci config (it helps a LOT to reduce build queue). If you take a look at log, there is SKIP_CI=true, I might be there is some bug , output is extended - #5289

Member

romani commented Nov 24, 2017

Something triggered shippable to skip running.

in all linux CIs we have SKIP_CI variable to skip execution while we debuging certain CI, so it skips execution if change only in other ci config (it helps a LOT to reduce build queue). If you take a look at log, there is SKIP_CI=true, I might be there is some bug , output is extended - #5289

@romani romani closed this Nov 24, 2017

timurt added a commit to timurt/checkstyle that referenced this issue Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment