New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractLoader: move out of api, rename, and remove abstract modifier #5338

Closed
rnveach opened this Issue Dec 9, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@rnveach
Member

rnveach commented Dec 9, 2017

Discussed at #5322 (review) ,

AbstractLoader should be moved outside of api package and renamed to XmlLoader and be changed to a concrete class.
Suppression in intellij-idea-inspections.xml needs to be removed.

@rnveach rnveach changed the title from Move and Rename AbstractLoader to Move, Rename, and remove abstract from AbstractLoader Dec 10, 2017

RoMaNiAsHkA pushed a commit to epam/checkstyle that referenced this issue Dec 19, 2017

Roman_Zhigunov Roman_Zhigunov
Issue checkstyle#5338: moved, renamed and removed abstact declaration…
… from AbstractLoader. Also moved and renamed AbstractLoaderTest and fixed suppressions for intellij idea and checkstyle

RoMaNiAsHkA pushed a commit to epam/checkstyle that referenced this issue Dec 20, 2017

Roman_Zhigunov Roman_Zhigunov
Issue checkstyle#5338: moved, renamed and removed abstact declaration…
… from AbstractLoader. Also moved and renamed AbstractLoaderTest and fixed suppressions for intellij idea and checkstyle

RoMaNiAsHkA pushed a commit to epam/checkstyle that referenced this issue Dec 20, 2017

Roman_Zhigunov Roman_Zhigunov
Issue checkstyle#5338: moved, renamed and removed abstact declaration…
… from AbstractLoader. Also moved and renamed AbstractLoaderTest and fixed suppressions for intellij idea and checkstyle

RoMaNiAsHkA pushed a commit to epam/checkstyle that referenced this issue Dec 20, 2017

Roman_Zhigunov Roman_Zhigunov
Issue checkstyle#5338: moved, renamed and removed abstact declaration…
… from AbstractLoader. Also moved and renamed AbstractLoaderTest and fixed suppressions for intellij idea and checkstyle

RoMaNiAsHkA pushed a commit to epam/checkstyle that referenced this issue Dec 20, 2017

Roman_Zhigunov Roman_Zhigunov
Issue checkstyle#5338: moved, renamed and removed abstact declaration…
… from AbstractLoader. Also moved and renamed AbstractLoaderTest and fixed suppressions for intellij idea and checkstyle

RoMaNiAsHkA pushed a commit to epam/checkstyle that referenced this issue Dec 20, 2017

Roman_Zhigunov Roman_Zhigunov
Issue checkstyle#5338: moved, renamed and removed abstact declaration…
… from AbstractLoader. Also moved and renamed AbstractLoaderTest and fixed suppressions for intellij idea and checkstyle

romani added a commit that referenced this issue Dec 22, 2017

Issue #5338: moved, renamed and removed abstact declaration from Abst…
…ractLoader. Also moved and renamed AbstractLoaderTest and fixed suppressions for intellij idea and checkstyle

@romani romani added this to the 8.6 milestone Dec 22, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Dec 22, 2017

Member

fix is merged

Member

romani commented Dec 22, 2017

fix is merged

@romani romani closed this Dec 22, 2017

@romani romani changed the title from Move, Rename, and remove abstract from AbstractLoader to AbstractLoader: move out of api, rename, and remove abstract modifier Dec 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment