Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix PMD violation CommentDefaultAccessModifier #5665
PMD rule CommentDefaultAccessModifier
The access modifier should be explicitly set to
This was referenced
Apr 19, 2018
from: #5743 (comment)
A brief conclusion:
conflict is with
We need to forbid usage of package private, all should be private or public (one day we will refactor all "protected" too).
@pbludov , please send us PR with privates and disabled AccessorClassGeneration.
@pbludov , thanks a lot, while we are waiting, can you send us PR with adding "public" to top level classes and "disabled AccessorClassGeneration". To allow us after release of jacoco, just to use "private" in all cases. Release of jacoco could take a while, it is better to minimize context of fix on our side, while we remember all details.