Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
new filter SuppressionXpathSingleFilter #5879
taken from #65 (comment)
Inlining of filters is set of a lot of issues, it is a problem already more then 10 year. Bunch of issues like this was in sourceforge tracker. Usage of additional files is problematic if verification should be done in multiple systems and IDEs (see #5756 (comment), ....).
idea (new filter with all properties of SuppressionXpathFilter external files):
vs (separate xml file part)
it will NOT be compact, but it will be in-lined in main config, and we do not do revolutionary changes in project for now to allow all types of tags and inline configuration under module tag.
All functionality of filtering is already implemented, new filter just need to reuse it.
referenced this issue
Jun 2, 2018
@rnveach , @jodastephen , as we agree on design, next step is to make it happen.
@jodastephen , as you are primary/first user of this feature, if you know any engineer who can make this implementation we will help him with with development process, and guide him on what to change and how. This issue is simple, even junior engineer can make it.
Implementation will contain pieces from https://github.com/checkstyle/checkstyle/blob/6893affeac7285afd16f8a389c7d65023d0c327a/src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressElement.java .