New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new filter SuppressionXpathSingleFilter #5879
Comments
@rnveach , @jodastephen , as we agree on design, next step is to make it happen. @jodastephen , as you are primary/first user of this feature, if you know any engineer who can make this implementation we will help him with with development process, and guide him on what to change and how. This issue is simple, even junior engineer can make it. |
Implementation will contain pieces from https://github.com/checkstyle/checkstyle/blob/6893affeac7285afd16f8a389c7d65023d0c327a/src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressElement.java . |
@jack870131 , can you help us with this issue ? |
I am on it. |
New filter was added. |
taken from #65 (comment)
Inlining of filters is set of a lot of issues, it is a problem already more then 10 year. Bunch of issues like this was in sourceforge tracker. Usage of additional files is problematic if verification should be done in multiple systems and IDEs (see #5756 (comment), ....).
Additional problem is that there are two types of suppressions:
idea (new filter with all properties of SuppressionXpathFilter external files):
another example:
vs (separate xml file part)
it will NOT be compact, but it will be in-lined in main config, and we do not do revolutionary changes in project for now to allow all types of tags and inline configuration under module tag.
All functionality of filtering is already implemented, new filter just need to reuse it.
Documentation: http://checkstyle.sourceforge.net/writingfilters.html
http://checkstyle.sourceforge.net/config_filters.html#SuppressionFilter
The text was updated successfully, but these errors were encountered: