Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify all modules are listed in contribution no exception configurations #5897

Closed
rnveach opened this issue Jun 9, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@rnveach
Copy link
Member

commented Jun 9, 2018

Identified at sevntu-checkstyle/sevntu.checkstyle#691 ,

checks-nonjavadoc-error.xml and checks-only-javadoc-error.xml in contribution should be verified that they contain all modules for no exception testing. No exception testing in wercker will verify XML is defined correctly, but nothing is ensuring it is populated with all modules.

we have missed one already - AnnotationOnSameLine , that was added at 8.2 version.

Code should be similar to what was added in sevntu.

@romani

This comment has been minimized.

@rnveach

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

The following checks are missing from non-exception configurations:

$ diff -u web.txt file.txt
--- web.txt	2019-03-10 11:18:51.970574847 -0400
+++ file.txt	2019-03-10 11:22:27.822574847 -0400
@@ -1,6 +1,7 @@
 AbbreviationAsWordInName
 AbstractClassName
 AnnotationLocation
+AnnotationOnSameLine
 AnnotationUseStyle
 AnonInnerLength
 ArrayTrailingComma
@@ -15,6 +16,7 @@
 CatchParameterName
 ClassDataAbstractionCoupling
 ClassFanOutComplexity
+ClassMemberImpliedModifier
 ClassTypeParameterName
 CommentsIndentation
 ConstantName
@@ -52,6 +54,7 @@
 IllegalToken
 IllegalTokenText
 IllegalType
+ImportControl
 ImportOrder
 Indentation
 InnerAssignment
@@ -59,9 +62,15 @@
 InterfaceIsType
 InterfaceMemberImpliedModifier
 InterfaceTypeParameterName
+JavadocMethod
+JavadocPackage
 JavadocParagraph
+JavadocStyle
 JavadocTagContinuationIndentation
+JavadocType
+JavadocVariable
 JavaNCSS
+LambdaParameterName
 LeftCurly
 LineLength
 LocalFinalVariableName
@@ -130,6 +139,7 @@
 SuperFinalize
 SuppressWarnings
 ThrowsCount
+TodoComment
 TrailingComment
 Translation
 TypecastParenPad
@@ -143,3 +153,4 @@
 VisibilityModifier
 WhitespaceAfter
 WhitespaceAround
+WriteTag
@romani

This comment has been minimized.

Copy link
Member

commented Mar 17, 2019

Fix is merged

@romani romani closed this Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.