Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce FileTabCharacter and RegexpSingleline for trailing whitespace over resources #5941

Open
romani opened this issue Jun 16, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@romani
Copy link
Member

commented Jun 16, 2018

uncomment configuration at: https://github.com/checkstyle/checkstyle/blob/master/config/checkstyle_resources_checks.xml#L18-L24

fix all violations.
It is better to split violation resolving in few PRs for each Check.
UT might be required to be updated - but ideally should not be updated.

@rnveach

This comment has been minimized.

Copy link
Member

commented Nov 4, 2018

RegexpSingleline has 1000 violations.
FileTab has 145 violations.

@rnveach

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

@romani When are tabs/spaces part of the tests outside of indentation/filetab ?
AST/Javadoc printing is picking them up in their results. Is it ok to change them and cause differences in tests?

A lot of inputs say they have tabs on purpose. naming, sizes, todo, whitespace, plain text suppression. It makes it a little tougher to identify them and will require more suppressions.

romani added a commit that referenced this issue Mar 10, 2019

rnveach added a commit to rnveach/checkstyle that referenced this issue Mar 10, 2019

rnveach added a commit that referenced this issue Mar 11, 2019

@rnveach rnveach added this to the 8.19 milestone Mar 11, 2019

@romani

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

When are tabs/spaces part of the tests outside of indentation/filetab ?

Naming should not have tabs .

A lot of inputs say they have tabs on purpose

It might be copy paste.

whitespace, plain text suppression.

Such grops can have tabs, but it is better to limit such inputs to certain list.

will require more suppressions.

Yes, I am completely ok with this. Ideally input files will have "withTabs" in names, so suppression will be easy. But as first step, list of inputs with certain names is good.

Vantuz added a commit to Vantuz/checkstyle that referenced this issue Apr 3, 2019

Vantuz added a commit to Vantuz/checkstyle that referenced this issue Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.