Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pitest: increase mutation coverage for javadoc profile to 100% #6295

Closed
rnveach opened this issue Dec 17, 2018 · 5 comments · Fixed by #11774
Closed

pitest: increase mutation coverage for javadoc profile to 100% #6295

rnveach opened this issue Dec 17, 2018 · 5 comments · Fixed by #11774
Labels
approved has bounty issue has some money incentive to fix it, https://www.bountysource.com/teams/checkstyle/issues miscellaneous

Comments

@rnveach
Copy link
Member

rnveach commented Dec 17, 2018 •
edited by romani

We should increase coverage for javadoc profile up to 100%.
This issue is a subtask of #3708
@rnveach
Copy link
Member Author

rnveach commented Dec 25, 2018

I can't reproduce these mutations surviving locally. The part that is being mutated is tagText after the ->.

checkstyle/.ci/pitest.sh

Lines 119 to 120 in 4490111

"JavadocTagInfo.java.html:<td class='covered'><pre><span class='survived'> .collect(Collectors.toMap(JavadocTagInfo::getName, tagName -&#62; tagName)));</span></pre></td></tr>"
"JavadocTagInfo.java.html:<td class='covered'><pre><span class='survived'> .collect(Collectors.toMap(JavadocTagInfo::getText, tagText -&#62; tagText)));</span></pre></td></tr>"

mutated return of Object value for com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTagInfo::lambda$1 to ( if (x != null) null else throw new RuntimeException ) → SURVIVED

rnveach added a commit to rnveach/checkstyle that referenced this issue Dec 25, 2018
@rnveach
Issue checkstyle#6295: added test cases to kill javadoc profile mutat…
5b4074c 
…ions
rnveach added a commit to rnveach/checkstyle that referenced this issue Dec 25, 2018
@rnveach
Issue checkstyle#6295: added test cases to kill javadoc profile mutat…
a4ea42d 
…ions
@rnveach rnveach mentioned this issue Dec 25, 2018
Merged
rnveach added a commit to rnveach/checkstyle that referenced this issue Dec 25, 2018
@rnveach
Issue checkstyle#6295: added test cases to kill javadoc profile mutat…
3c6cfc2 
…ions
romani pushed a commit that referenced this issue Dec 25, 2018
@rnveach @romani
Issue #6295: added test cases to kill javadoc profile mutations
00cdc4e
@romani
Copy link
Member

romani commented Dec 25, 2018 •
edited

Did you try this on Windows or Linux?
I remember that u generated such output on my local Linux, but on some old version of pitest

@rnveach
Copy link
Member Author

rnveach commented Dec 26, 2018

Running pitest produces it on windows and linux, but I can't reproduce it using eclipse on Windows. I get exceptions when replacing the code with null. I haven't tried linux.

rnveach added a commit to rnveach/checkstyle that referenced this issue Dec 26, 2018
@rnveach
Issue checkstyle#6295: changed code to remove javadoc profile mutations
c5c1c83
@rnveach rnveach mentioned this issue Dec 26, 2018
Merged
rnveach added a commit to rnveach/checkstyle that referenced this issue Dec 27, 2018
@rnveach
Issue checkstyle#6295: changed code to remove javadoc profile mutations
33bd818
rnveach added a commit to rnveach/checkstyle that referenced this issue Dec 27, 2018
@rnveach
Issue checkstyle#6295: changed code to remove javadoc profile mutations
8894eaf
rnveach added a commit to rnveach/checkstyle that referenced this issue Dec 27, 2018
@rnveach
Issue checkstyle#6295: changed code to remove javadoc profile mutations
4507795
romani pushed a commit that referenced this issue Dec 28, 2018
@rnveach @romani
Issue #6295: changed code to remove javadoc profile mutations
9198b1f
@romani romani added the has bounty issue has some money incentive to fix it, https://www.bountysource.com/teams/checkstyle/issues label Apr 13, 2019
@rnveach rnveach mentioned this issue Mar 8, 2020
Closed
@wltan wltan mentioned this issue May 9, 2020
Closed
strkkk added a commit to strkkk/checkstyle that referenced this issue Dec 17, 2020
@strkkk
Issue checkstyle#6295: resolve pitest issues for JavadocTagInfo
70302e9
@strkkk strkkk mentioned this issue Dec 17, 2020
Merged
romani pushed a commit that referenced this issue Dec 21, 2020
@strkkk @romani
Issue #6295: resolve pitest issues for JavadocTagInfo
72f2aea
@ahmedmohiduet
Copy link

Hello, let me know if this issue still has bounty open. Would love to contribute

@romani
Copy link
Member

romani commented Jan 31, 2021

@ahmedmohiduet , still open, please fix issue and get a bounty.

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 27, 2022
@Vyom-Yadav
Issue checkstyle#6295: Increase mutation coverage for javadoc profile…
9fcdf03 
… to 100%
@Vyom-Yadav Vyom-Yadav mentioned this issue Jun 27, 2022
Merged
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jul 1, 2022
@Vyom-Yadav
Issue checkstyle#6295: Increase mutation coverage for javadoc profile…
8341a8d 
… to 100%
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jul 1, 2022
@Vyom-Yadav
Issue checkstyle#6295: Increase mutation coverage for javadoc profile…
8cf7036 
… to 100%
romani pushed a commit that referenced this issue Jul 2, 2022
@Vyom-Yadav @romani
Issue #6295: Increase mutation coverage for javadoc profile to 100%
685a1ac
@Rahulkhinchi03 Rahulkhinchi03 mentioned this issue Jul 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved has bounty issue has some money incentive to fix it, https://www.bountysource.com/teams/checkstyle/issues miscellaneous
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #6295: Increase mutation coverage for javadoc profile to 100% Vyom-Yadav/checkstyle
3 participants
@romani @ahmedmohiduet @rnveach