Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation: indentation level is being corrupted in class fields #6308

Closed
rnveach opened this Issue Dec 22, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@rnveach
Copy link
Member

rnveach commented Dec 22, 2018

While running regression for pitest, I have gotten differences that I couldn't reproduce locally on a single file run. I believe one reason is because the IndentLevel is being corrupted as we use the same class instance among multiple fields.

I tried to remove the cache of this field, but it caused regression to stall for 10 hours on apache ant's BlockSort.java.

I rework IndentLevel class to be immutable, and I am seeing regression differences.

From the changes I made, I believe ObjectBlockHandler is the one doing the corruption. It is modifying another class' fields by calling addAcceptedIndent on an IndentLevel it didn't create.

rnveach added a commit to rnveach/checkstyle that referenced this issue Dec 22, 2018

rnveach added a commit to rnveach/checkstyle that referenced this issue Dec 22, 2018

rnveach added a commit to rnveach/checkstyle that referenced this issue Dec 22, 2018

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 15, 2019

romani added a commit that referenced this issue Feb 1, 2019

@romani romani added this to the 8.18 milestone Feb 1, 2019

@romani

This comment has been minimized.

Copy link
Member

romani commented Feb 1, 2019

Fix is merged

@romani romani closed this Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.