Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links in header comment block of sun_checks.xml are outdated #6420

Closed
zenglian opened this issue Feb 11, 2019 · 7 comments

Comments

Projects
None yet
3 participants
@zenglian
Copy link

commented Feb 11, 2019

Oracle bought sun in 2009. The links in this file is not valid now. The name "sun" is outdated.

https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml#L13

@rnveach

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

Even if they were bought out, the original document specifically says it was written by sun, so that is why we are still referencing it as the sun config, since it follows their style guide.

https://www.oracle.com/technetwork/java/javase/documentation/codeconventions-139411.html#16712

This document reflects the Java language coding standards presented in the Java Language Specification , from Sun Microsystems, Inc.

Has oracle created their own code conventions for Java and thus outdated the original sun ones? Unless that happens, I think we should continue with sun. Even if it does happen, we may or may not keep them as separate guides depending on how much was changed.

Even our own links in the config are outdated, so I feel it is fine to atleast update the links to their newest locations.

@zenglian

This comment has been minimized.

Copy link
Author

commented Feb 12, 2019

You are right. So please fix the broken links only.

@zenglian zenglian closed this Feb 12, 2019

@rnveach

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Issue has to stay open for us to work on it once @romani approves it.

@rnveach rnveach reopened this Feb 12, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

on what page we have bad link ?

@rnveach

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

@romani We are discussing the sun XML configuration file. Most of the links listed are bad or old.
https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml#L13 This one doesn't work anymore. I found the code conventions through googling.

@romani romani changed the title sun_checks.xml links in header comment block of sun_checks.xml are outdated Feb 12, 2019

@romani romani added the approved label Feb 12, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

@zenglian , issue is approved, please be welcome with PR to fix links.

rnveach added a commit to rnveach/checkstyle that referenced this issue Mar 10, 2019

romani added a commit that referenced this issue Mar 10, 2019

@romani romani added this to the 8.19 milestone Mar 10, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

Fix is merged

@romani romani closed this Mar 10, 2019

Vantuz added a commit to Vantuz/checkstyle that referenced this issue Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.