Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MissingOverride javaFiveCompatibility true in checkstyle_checks.xml #6452

Closed
Vampire opened this issue Feb 22, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@Vampire
Copy link
Contributor

commented Feb 22, 2019

https://checkstyle.org/config_annotation.html#MissingOverride

The description of MissingOverride javaFiveCompatibility says that it should be avoided and is recommended to only use it on Java 5 source. But in checkstyle_checks.xml it is set to true. Your sources are Java 8 and this file is recommended as a starter for new users that want all checks, so maybe this should be set to false / removed?

https://github.com/checkstyle/checkstyle/blob/master/config/checkstyle_checks.xml#L175

@romani

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

We should not use this property with true value, we should use Check in default config.

@romani romani added the approved label Feb 23, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Mar 6, 2019

Issue checkstyle#6452: Use default value false for javaFiveCompatibil…
…ity property of MissingOverride check in checkstyle_checks.xml

@romani romani closed this in #6519 Mar 8, 2019

romani added a commit that referenced this issue Mar 8, 2019

Issue #6452: Use default value false for javaFiveCompatibility proper…
…ty of MissingOverride check in checkstyle_checks.xml

@romani romani added the miscellaneous label Mar 8, 2019

@romani romani added this to the 8.19 milestone Mar 8, 2019

Vantuz added a commit to Vantuz/checkstyle that referenced this issue Apr 3, 2019

Issue checkstyle#6452: Use default value false for javaFiveCompatibil…
…ity property of MissingOverride check in checkstyle_checks.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.